Add M5Stack Dial #471
Open
Add M5Stack Dial #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
UF2_BOARD_IDin your board.h follow correct format from uf2 specsThis checklist items that are not applicable to your PR can be deleted.
Description of Change
Adding new, distinct entry for the M5Stack Dial, separate from the M5Stack Stamp S3 inside of it (that can run separately as well).
Adding the M5Stack Dial as its own UF2 in an attempt to resolve adafruit/circuitpython-org#1721 (see issue for additional information and root-causing). Essentially, the M5Stack Dial uses the M5Stack Stamp S3 as a cardputer, so I essentially copied the information from there since it should be one-to-one (minus some old TFT code that can't be used if the Stamp S3 is in the Dial anyway). I figured it should still show as the Stamp S3, but this should unblock the installer issue.