Skip to content

Fix: Resolved dependencies conflicts#83

Closed
MauroAbidalCarrer wants to merge 2 commits into
adamkarvonen:mainfrom
MauroAbidalCarrer:fix_dependencies
Closed

Fix: Resolved dependencies conflicts#83
MauroAbidalCarrer wants to merge 2 commits into
adamkarvonen:mainfrom
MauroAbidalCarrer:fix_dependencies

Conversation

@MauroAbidalCarrer

Copy link
Copy Markdown

This PR removes the dependencies conflicts between the cnostraints and pyproject files:

  • I commneted out sae-lens 5.4.1 pinning made in fix: pinning saelens to v5.x.x #75 since Fix graphing utils' ax.set_xscale("log") calls #85 has made SAEBench compatible with sae-lens 6.x.x.
  • I commented out torchvision dependency in pyproject.toml since it is not used and caused an import error in the demo.
  • Pinned datasets dependency to 3.6.0 because it raised a deprecation error in the demo. This was due to the reliance on a deprecated dataset (openwebtxt) download.

Mauro Abidal Carrer added 2 commits November 18, 2025 14:59
…rchvision dependemcy in pyproject. Pined datasets version to 3.6.0 to avoid openwebtxt download deprecation error.
@chanind

chanind commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

I can't reproduce any issues with dependencies / SAELens running the notebook with pip install -e .. SAELens fix is here: decoderesearch/SAELens#587

Why do we have constraints.txt anyway? pyproject.toml should be the source of truth for the repo dependencies I would think?

@adamkarvonen

Copy link
Copy Markdown
Owner

This was fixed in #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants