Skip to content

#183 relax lxml version constraint#184

Merged
adbar merged 3 commits intoadbar:masterfrom
zhemaituk:patch-1
Aug 1, 2025
Merged

#183 relax lxml version constraint#184
adbar merged 3 commits intoadbar:masterfrom
zhemaituk:patch-1

Conversation

@zhemaituk
Copy link
Contributor

@zhemaituk zhemaituk commented Jul 1, 2025

Addresses #183

@adbar adbar linked an issue Jul 14, 2025 that may be closed by this pull request
@adbar
Copy link
Owner

adbar commented Jul 14, 2025

@zhemaituk Something changed in the way black formats code, it would be nice if you could update this dependency and its behavior as well.

@zhemaituk
Copy link
Contributor Author

@adbar formatting updated

@zhemaituk
Copy link
Contributor Author

@adbar can you kick off the build please?

@zhemaituk
Copy link
Contributor Author

@adbar there are further checks failed by mypy -p htmldate, which has nothing to do with my changes.

But if you like I can change:

htmldate/extractors.py:37: error: List comprehension has incompatible type List[str]; expected List[Literal['timestamp', 'relative-time', 'custom-formats', 'absolute-time', 'no-spaces-time']] [misc]
FROM:

        "PARSERS": [
            p
            for p in default_parsers
            if p not in ("no-spaces-time", "relative-time", "timestamp")
        ],

TO:

        "PARSERS": [
            "custom-formats",
            "absolute-time",
        ],

@adbar
Copy link
Owner

adbar commented Jul 30, 2025

@zhemaituk Yes, that'd be nice, thanks!

@zhemaituk
Copy link
Contributor Author

@adbar done, black --check --diff htmldate and mypy -p htmldate pass for me on python 3.13

@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (1074ee7) to head (507cf75).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   99.88%   99.88%   -0.01%     
==========================================
  Files           8        8              
  Lines         850      849       -1     
==========================================
- Hits          849      848       -1     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adbar adbar merged commit b324225 into adbar:master Aug 1, 2025
20 of 21 checks passed
@PLPeeters
Copy link

@adbar Any chance you could push a new release with this? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lxml 6.0.0 support

3 participants