fix: resolve Slack/WorkOS user ID duplicates in chapter memberships #669
+120
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause: Users who joined chapters via Slack had their Slack user ID stored. When they later linked their WorkOS account via web login, they got a different ID. The slack_user_mappings table linked these, but membership/leader records still had the old Slack IDs, causing duplicates and broken permissions. Solution: - Add resolveToCanonicalUserId() helper to resolve Slack IDs to WorkOS IDs - Apply resolution in all write paths: addMembership, addLeader, setLeaders, addMembershipWithInterest - Apply resolution in all read/check paths: isMember, isLeader, getMembership, removeMembership, removeLeader, deleteMembership, getCommitteesLedByUser - Add migration 149 to consolidate existing duplicate records - Add canonical_user_id to WorkingGroupLeader type for frontend compatibility - Update frontend and backend leader checks to use canonical_user_id 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Migration 149: Use joined_at instead of UUID id for deduplication (UUIDs are not sequential, so id comparison doesn't determine age) - Empty changeset since this doesn't impact the protocol 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Migration 149 and 150 already exist on main branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicate members appearing in chapter member lists and broken leader permissions when users have both Slack and web (WorkOS) accounts.
Root cause: Users who joined chapters via Slack had their Slack user ID stored (e.g.,
U1234567). When they later linked their WorkOS account via web login, they got a different ID (e.g.,user_abc). Theslack_user_mappingstable linked these together, but the membership/leader records still had the old Slack IDs.Changes
Write-time ID resolution
resolveToCanonicalUserId()helper that checksslack_user_mappingsto resolve Slack IDs to WorkOS IDsaddMembership()addLeader()setLeaders()addMembershipWithInterest()Read/check path resolution
isMember()isLeader()getMembership()removeMembership()removeLeader()deleteMembership()getCommitteesLedByUser()Data migration
Frontend compatibility
canonical_user_idtoWorkingGroupLeadertypecanonical_user_idTest plan
🤖 Generated with Claude Code