Skip to content

Add dropzone accessibility#10

Open
RakibRahman wants to merge 3 commits into
addyosmani:mainfrom
RakibRahman:add-dropzone-accessibility
Open

Add dropzone accessibility#10
RakibRahman wants to merge 3 commits into
addyosmani:mainfrom
RakibRahman:add-dropzone-accessibility

Conversation

@RakibRahman

Copy link
Copy Markdown

feat: add keyboard navigation support to DropZone

  • Made DropZone focusable with tabIndex={0}.
  • Added onKeyDown handler for Enter/Space key support.
  • Improved accessibility with role="button" and aria-label.
  • Enhanced focus styles for better usability.

Preview:
accessibility

@netlify

netlify Bot commented Feb 8, 2025

Copy link
Copy Markdown

Deploy Preview for squish-image ready!

Name Link
🔨 Latest commit 896455e
🔍 Latest deploy log https://app.netlify.com/sites/squish-image/deploys/67c8b07be5c9b30008086629
😎 Deploy Preview https://deploy-preview-10--squish-image.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this - it's a helpful addition. 👍 You can use it with just a keyboard now!

@coliff

coliff commented Feb 21, 2025

Copy link
Copy Markdown

Would be great to fix this accessibility issue too:
image

@RakibRahman

Copy link
Copy Markdown
Author

fixed accessibility issues for the image quality input.

@RakibRahman RakibRahman requested a review from coliff March 5, 2025 20:17
@mathcrln

mathcrln commented Aug 4, 2025

Copy link
Copy Markdown

Hey @coliff, I have been checking out this pull request along with a couple of other recent ones and I'm loving all of the changes introduced by all these contributors! I see you already approved this PR, what would it take to merge it into production?

I'm already excited to use the changes introduced in #13 and #15 :)

@coliff

coliff commented Aug 4, 2025

Copy link
Copy Markdown

I'm not an admin of this repo... I think only @addyosmani is able to merge. Hopefully he'll get round to it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants