Skip to content

Feat/issue 5 may 4th takeover#37

Merged
adhit-r merged 3 commits into
adhit-r:mainfrom
theshantanujoshi:feat/issue-5-may-4th-takeover
Jun 23, 2026
Merged

Feat/issue 5 may 4th takeover#37
adhit-r merged 3 commits into
adhit-r:mainfrom
theshantanujoshi:feat/issue-5-may-4th-takeover

Conversation

@theshantanujoshi

Copy link
Copy Markdown
Contributor

This PR addresses Issue #5 by implementing a special "May the Fourth" (Star Wars Day) takeover for the landing page.

Key Changes:

  • Themed Landing Page: On May 4th, the landing page tagline shifts to "May the Fourth be with you" and the Holocron brand glyph/crosshair adopt Yoda's lightsaber green.
  • Special Banner: Added a tiny, dismissible MayTheFourthBanner that appears at the top of the page, offering a link to initialize a "random-vergence cross-pivot" (archive explorer).
  • Takeover Components: Created a suite of takeover-aware components in components/MayTheFourth.tsx to handle the date logic and visual shifts.
  • Hydration & Respect for Settings:
    • Uses client-side date detection to ensure the takeover is local to the user's timezone.
    • Correctly handles hydration to avoid server/client mismatches.
    • Respects prefers-reduced-motion settings.
  • Persistence: The banner dismissal is persisted in sessionStorage for the duration of the session.

Verification:

I verified the implementation by mocking the date to May 4th in the local environment and confirming that the UI elements (tagline, brand glyph, banner, and crosshair) all update correctly. I also verified that the takeover is inactive on other days (e.g., today, May 13th).

Closes #5

@safedep

safedep Bot commented May 13, 2026

Copy link
Copy Markdown

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

Installation is not linked with SafeDep Tenant. Click here to optionally link your GitHub App installation with SafeDep Tenant.

This report is generated by SafeDep Github App

@adhit-r

adhit-r commented May 14, 2026

Copy link
Copy Markdown
Owner

Holding this before merge. npm run typecheck passes, but git diff --check fails due to trailing whitespace and an extra blank line at EOF.

One behavior mismatch also needs cleanup: the CTA says “Initialize random-vergence cross-pivot”, but it only links to /explore. Please either implement the random selection/cross-pivot behavior or change the CTA copy to match what the link actually does.

@adhit-r adhit-r merged commit a3218ef into adhit-r:main Jun 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

May the Fourth landing-page takeover

2 participants