Conversation
This was referenced Aug 28, 2026
Amp-Thread-ID: https://ampcode.com/threads/T-01a047e7-d402-72a8-ad22-eb5d3d3df6b1 Co-authored-by: Aditya Balakrishnan <adibalak1925@gmail.com>
Owner
Author
|
Landed on main as part of the consolidated, rebased stack ending at e9bd4bd. Verified this PR has no patches absent from origin/main, so closing the now-redundant stacked PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/rag-pipelineThis is an independent foundation slice replacing the pure reusable portion of #10. It has no dependency on #10 or any other split/slice. It intentionally excludes Chroma/Gemini clients, FastAPI, NotebookLM integration, downloaded sources/data, notebooks, generated wiki content, duplicated agent configuration, and root hook/tooling changes. This PR does not modify or close #10.
Verification
python3 -m unittest discover -s tests -v(fromapps/rag-pipeline): 10 passedmise exec -- pnpm --filter @agentx/rag-pipeline test: 10 passedpython3 -m pip wheel --no-deps --wheel-dir <temp> .: builtagentx_rag_core-0.1.0-py3-none-any.whlmise exec -- pnpm build: passed (19 workspace projects)git diff --check: passedExisting root-check failures
mise exec -- pnpm test: 360 passed, 1 skipped, 1 failed. The pre-existingpackages/core/tests/injection.test.tscustom ADP handler assertion also fails when run alone; this PR does not touch that code.mise exec -- pnpm check: pre-existing formatting findings in 23 files outside this PR. The newpackage.jsonpasses the formatter; the scoped lint phase reports no lintable files.The initial red TDD run failed with
ModuleNotFoundError: No module named 'rag'before implementation; the final Python suite is green.