Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in transcribeAudio tool - #28

Merged
adihex merged 1 commit into
mainfrom
sentinel-fix-command-injection-11319838458880066128
Sep 5, 2026
Merged

adihex merged 1 commit into
mainfrom
sentinel-fix-command-injection-11319838458880066128

Conversation

@adihex

@adihex adihex commented Sep 4, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Command injection vulnerability in the binaryAvailable function inside apps/zettel/src/tools/transcribe.ts. The variable bin (which is sourced from the WHISPER_BIN environment variable) was interpolated into a shell command sh -c command -v ${bin} without sanitization.
🎯 Impact: If the environment variable contained shell metacharacters (e.g. whisper-cli; rm -rf /), it would be executed by the shell, leading to arbitrary command execution on the host machine.
πŸ”§ Fix: Replaced the shell execution sh -c command -v with the safe argument array format using the which utility: execFileSync("which", [bin], { stdio: "ignore" }). This directly invokes which without invoking a shell parser, effectively eliminating the command injection vulnerability.
βœ… Verification: Ran pnpm test in the apps/zettel directory, and reviewed the change.


PR created automatically by Jules for task 11319838458880066128 started by @adihex

Co-authored-by: adihex <82704954+adihex@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@adihex
adihex merged commit b7a7f3b into main Sep 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant