π‘οΈ Sentinel: [HIGH] Fix command injection in transcribeAudio tool - #28
Conversation
Co-authored-by: adihex <82704954+adihex@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Command injection vulnerability in the
binaryAvailablefunction insideapps/zettel/src/tools/transcribe.ts. The variablebin(which is sourced from theWHISPER_BINenvironment variable) was interpolated into a shell commandsh -c command -v ${bin}without sanitization.π― Impact: If the environment variable contained shell metacharacters (e.g.
whisper-cli; rm -rf /), it would be executed by the shell, leading to arbitrary command execution on the host machine.π§ Fix: Replaced the shell execution
sh -c command -vwith the safe argument array format using thewhichutility:execFileSync("which", [bin], { stdio: "ignore" }). This directly invokeswhichwithout invoking a shell parser, effectively eliminating the command injection vulnerability.β Verification: Ran
pnpm testin theapps/zetteldirectory, and reviewed the change.PR created automatically by Jules for task 11319838458880066128 started by @adihex