fix: resolve signature birthday cakes broken images and sync dynamic weight pricing logic#706
Open
moon-26k wants to merge 2 commits into
Open
fix: resolve signature birthday cakes broken images and sync dynamic weight pricing logic#706moon-26k wants to merge 2 commits into
moon-26k wants to merge 2 commits into
Conversation
|
@moon-26k is attempting to deploy a commit to the adithyansubramani1-1657's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @adithyan-css, I have fixed the broken images and synced the dynamic weight pricing logic for birthday cakes. Could you please authorize the Vercel deployment check when you get a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Overview
This Pull Request fixes the broken image rendering issue and incorrect pricing calculations in the Signature Birthday Cakes section.
🛠️ Changes Made
.pngassets for all birthday cake variations (pineapplecake.png,chocoholiccake.png,black-forest-cake.png,Cheesecake.png) inside thepublic/assets/directory to replace the missing external URLs.window.BIRTHDAY_FALLBACKSand image reference handlers to target the correct local filename strings and extensions (.png).window.setCakeWeightandwindow.calculateBdayPriceto ensure that switching between weights (0.5kg,1.0kg,1.5kg,2.0kg) dynamically recalculates the exact price based on the individual flavor's base price configuration (e.g., ₹950 for Dutch Truffle, ₹675 for Pineapple).toLowerCase().trim()) to prevent any silent breaks due to text case mismatches.🚀 How to Test
#Closes #256