Mastery Score should be zero if not defined#7
Conversation
|
@cawerkenthin I would be grateful for your thoughts on this pull request. Should the cmi5Controller use zero for a mastery score if it is undefined or would you say it was up to the cmi5Controller client to check for the possibility of undefined? As it stands this AU always sends failed statements because the cmi5.xml does not contain a mastery score. Currently in the following, cmi5Controller.getMasteryScore() is always undefined. if (score >= cmi5Controller.getMasteryScore()) {
SendStatement("Passed", score);
} else {
SendStatement("Failed", score);
} |
|
I think there are two issues here:
|
|
I think that it is ok for a AU not to have a mastery score but still send passed and failed statements, what if the move on criteria was passed? |
|
My question would be is it ok for an AU to have its own build concept of a passing score as long as it was overridden by the mastery score (if one was present) |
If the LMS does not set a mastery score then the value should be assumed to be 0 because undefined is not a valid value.