Repository navigation
Add per-span time windows for best-price sensors - #24
Merged
Merged
Conversation
Introduce per-span time restrictions for "best price" sensors. Added utils.parse_spans to parse span strings like "1, 3[22:00-06:00], 6" (returns (span, start, end)), and updated binary_sensor to use parsed spans and pass span-specific restrict_start/restrict_end to each sensor (falling back to global config when not provided). Updated README, translations and changelog, bumped manifest version to 1.1.9, and extended tests (parse_spans unit tests and coordinator test for span-specific restriction precedence). Warnings are logged for invalid span or time formats.
Remove extraneous trailing spaces and blank lines in custom_components/tibber-extended/utils.py and tests (tests/test_coordinator.py, tests/test_utils.py). Adjust minor formatting in imports and list/tuple spacing in tests. No functional changes were made; this is purely whitespace/style cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce per-span time restrictions for "best price" sensors. Added utils.parse_spans to parse span strings like "1, 3[22:00-06:00], 6" (returns (span, start, end)), and updated binary_sensor to use parsed spans and pass span-specific restrict_start/restrict_end to each sensor (falling back to global config when not provided). Updated README, translations and changelog, bumped manifest version to 1.1.9, and extended tests (parse_spans unit tests and coordinator test for span-specific restriction precedence). Warnings are logged for invalid span or time formats.