Skip to content

fix(ew-setup): use canvas editor path in sidekick editUrlPattern #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannessolo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ew-setup): use canvas editor path in sidekick editUrlPattern #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/unit/ew-setup/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe('buildConfigWithEwEnabled', () => {
});

describe('hasCorrectSidekickConfig', () => {
const PATTERN = 'https://da.live/#/{{org}}/{{site}}{{pathname}}';
const PATTERN = 'https://da.live/canvas#/{{org}}/{{site}}{{pathname}}';
it('returns true when editUrlPattern matches', () => {
expect(hasCorrectSidekickConfig({ editUrlPattern: PATTERN })).to.be.true;
});
Expand All @@ -115,7 +115,7 @@ describe('hasCorrectSidekickConfig', () => {
});

describe('buildUpdatedSidekickConfig', () => {
const PATTERN = 'https://da.live/#/{{org}}/{{site}}{{pathname}}';
const PATTERN = 'https://da.live/canvas#/{{org}}/{{site}}{{pathname}}';
it('creates bare minimum config when existingJson is null', () => {
const result = buildUpdatedSidekickConfig(null);
expect(result).to.deep.equal({ project: 'Experience Workspace Project', editUrlPattern: PATTERN });
Expand Down
2 changes: 1 addition & 1 deletion tools/ew-setup/ew-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ class EwSetupApp extends LitElement {
}

_renderStep2() {
const editUrlPattern = 'https://da.live/#/{{org}}/{{site}}{{pathname}}';
const editUrlPattern = 'https://da.live/canvas#/{{org}}/{{site}}{{pathname}}';

if (this._sidekickStatus === 'loading') {
return html`
Expand Down
2 changes: 1 addition & 1 deletion tools/ew-setup/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function buildConfigWithEwEnabled(existingJson) {
return result;
}

const SIDEKICK_EDIT_URL = 'https://da.live/#/{{org}}/{{site}}{{pathname}}';
const SIDEKICK_EDIT_URL = 'https://da.live/canvas#/{{org}}/{{site}}{{pathname}}';

export function hasCorrectSidekickConfig(json) {
return json?.editUrlPattern === SIDEKICK_EDIT_URL;
Expand Down
Loading