Dev2master 18082026 - #1964
Merged
Merged
Conversation
* added theme editor support for table component * updated README for the table component theme editor support * address review comments for table theme editor styleConfig - add hover, focus-visible, disabled states to tableAddButton and tableRemoveButton for consistency with tableSortButton - use :focus-visible on sort button and add/remove buttons to match theme canvas SCSS Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
updating af2-web-runtime to v1.0.2
Adding File attachment scanning support.
…odes (#1957) Change from sling:Folder to nt:unstructured so AEM resolves component resource type inheritance correctly. Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
[FORMS-27260] Removing datepicker v2 and updating a11y fixes in v1
…der (#1958) * fixing the Filevault issue * added jcr:primaryType=nt:unstructured to the child Nodes --------- Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local>
…race) (#1960) A config-dialog submit fires an asynchronous editable re-render that repositions overlays and hides the shared #EditableToolbar. The test proceeded straight to openEditableToolbar, so the late re-render tore the toolbar down after it was opened and the trailing should('be.visible') (commands.js:311, never re-clicks) timed out with "#EditableToolbar has display: none". At retries=0 this reproduced 4/5; masked but still ~41% flaky at CI retries=3. - Add central cy.submitConfigureDialog() command that registers the same cq-editables-updated + cq-overlays-repositioned listeners deleteComponentByPath uses BEFORE submit and blocks until both fire, so the editor is settled before the next openEditableToolbar. Reusable by the other submit sites across specs. - Use it in the Forms-editor and Sites-editor flows of the spec. - Suppress the intermittent CoralUI3 "Cannot create property '_namespace' on boolean 'true'" editor-bootstrap error in the index.js allow-list; it is racy, self-recovers, and has no functional impact on the form. Verified: 20 consecutive post-fix runs at retries=0 with zero failures (baseline 4/5 failing). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adding component versioning requirements to ensure valid component version bumping
[FORMS-26375] Updating button main selector
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: