Skip to content

Added canvas theme for tableComponent in core component - #106

Merged
armaang1729 merged 4 commits into
mainfrom
TableComponentTheme
Jun 18, 2026
Merged

Added canvas theme for tableComponent in core component#106
armaang1729 merged 4 commits into
mainfrom
TableComponentTheme

Conversation

@armaang1729

Copy link
Copy Markdown
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@armaang1729 armaang1729 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by claude :

Here's my assessment:

No breaking changes. The PR adds a brand-new file (_table.scss) and new SVG assets — nothing existing is modified except appending one @import line to theme.scss. All SCSS variables used ($dark-gray, $silver, $panel-bg-color, $wizard-bg-color, $very-light-gray, $focus-ring-color, $white) are defined in _variables.scss.

The only thing worth noting (non-breaking, cosmetic):

The three sort SVGs have fill="#ff13dc" (hot pink) on an opacity-0 rect — looks like a debug artifact from the SVG editor, but since opacity="0" it's invisible at runtime.
.cell-wrapper { width: 80% } at line 214 of _table.scss is a generic class name that could collide with other styles, but it's not breaking anything today.

LGTM — safe to merge.

@armaang1729
armaang1729 merged commit ffa9103 into main Jun 18, 2026
3 checks passed
@armaang1729
armaang1729 deleted the TableComponentTheme branch June 18, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant