Skip to content

FORMS-18796: Control text lacks 4.5:1 contrast ratio on hover or focus @sunnym @vavarshn - #16

Merged
vaibhav2601 merged 2 commits into
mainfrom
ens37130/FORMS-18796
Jul 31, 2025
Merged

FORMS-18796: Control text lacks 4.5:1 contrast ratio on hover or focus @sunnym @vavarshn#16
vaibhav2601 merged 2 commits into
mainfrom
ens37130/FORMS-18796

Conversation

@stefan-dragomir

@stefan-dragomir stefan-dragomir commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Description

Related Issue

https://jira.corp.adobe.com/browse/FORMS-18796

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Before:
Before

After:
After

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Comment thread src/site/_mixins.scss Outdated

&:not([disabled]):focus-within label {
color: $widget-focus-text-color;
opacity: 100%;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opacity property takes a number between 0 and 1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@amit-mnnit amit-mnnit left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comment.

@stefan-dragomir

Copy link
Copy Markdown
Contributor Author

Updated opacity.

@vaibhav2601

Copy link
Copy Markdown

@amit-mnnit Recommended changes are done. Please have a look again. LGTM.

@vaibhav2601
vaibhav2601 merged commit 4f91869 into main Jul 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants