Fix/cext-4448#235
Merged
Merged
Conversation
brasewel
requested changes
Apr 7, 2025
| if (isNaN(durationInMs) || !match) { | ||
| throw new Error( | ||
| 'Invalid format. The past time window should be in minutes, for example, "20 mins", "15 minutes".', | ||
| 'Invalid format. The past time window should be integer, for example, "20", "15".', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Invalid format. The past time window should be integer, for example, "20", "15".', | |
| 'Invalid format. The past time window should be an integer, for example, "20", "15".', |
| ); | ||
| test.each(invalidDurations)('throws an error for non-numeric input "%s"', invalidPastDuration => { | ||
| expect(() => parsePastDuration(invalidPastDuration)).toThrow( | ||
| 'Invalid format. The past time window should be integer, for example, "20", "15".', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Invalid format. The past time window should be integer, for example, "20", "15".', | |
| 'Invalid format. The past time window should be an integer, for example, "20", "15".', |
amolina-adobe
suggested changes
Apr 7, 2025
jhadobe
suggested changes
Apr 7, 2025
Co-authored-by: Jared Hoover <98363870+jhadobe@users.noreply.github.com>
Co-authored-by: Andrew Molina <44038475+amolina-adobe@users.noreply.github.com>
jhadobe
approved these changes
Apr 9, 2025
amolina-adobe
approved these changes
Apr 14, 2025
kmaschi
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: