Skip to content

Cext 4511#246

Merged
AjazSumaiya merged 13 commits into
developfrom
CEXT-4511
May 6, 2025
Merged

Cext 4511#246
AjazSumaiya merged 13 commits into
developfrom
CEXT-4511

Conversation

@nvyasadobe
Copy link
Copy Markdown
Contributor

@nvyasadobe nvyasadobe commented Apr 21, 2025

Description

This pull request is to perform encryption of Newrelic license key in CLI, in case of set log forwarding.

Related Issue

https://jira.corp.adobe.com/browse/CEXT-4511

Motivation and Context

Required to encrypt Newrelic license.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvyasadobe nvyasadobe marked this pull request as ready for review April 22, 2025 13:18
Copy link
Copy Markdown
Contributor

@brasewel brasewel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be targetted to develop

@brasewel brasewel added the enhancement New feature or request label Apr 24, 2025
@nvyasadobe
Copy link
Copy Markdown
Contributor Author

This should be targetted to develop

@brasewel : I targeted epic, so that I can get an alpha to test. Also I targeted epic and not develop, because if this change go prior of decryption changes(SMS), set log-forwarding command will fail.
Please confirm if you want me to target develop branch(I will update package.json to publish beta in this case)

@brasewel
Copy link
Copy Markdown
Contributor

This should be targetted to develop

@brasewel : I targeted epic, so that I can get an alpha to test. Also I targeted epic and not develop, because if this change go prior of decryption changes(SMS), set log-forwarding command will fail. Please confirm if you want me to target develop branch(I will update package.json to publish beta in this case)

Please publish beta packages. This feature is now in prod, we don't want to be using this epic branch anymore.

@nvyasadobe nvyasadobe changed the base branch from epic/log-forwarding to develop April 24, 2025 18:18
Comment thread src/commands/api-mesh/config/set/log-forwarding.js Outdated
Comment thread src/commands/api-mesh/config/set/log-forwarding.js Outdated
Comment thread src/utils.js Outdated
Comment thread src/utils.js Outdated
@AjazSumaiya AjazSumaiya requested review from dani97 and kmaschi April 30, 2025 14:22
AjazSumaiya and others added 2 commits April 30, 2025 19:55
Co-authored-by: Brasewel Noronha <100383619+brasewel@users.noreply.github.com>
brasewel
brasewel previously approved these changes Apr 30, 2025
kmaschi
kmaschi previously approved these changes May 5, 2025
@AjazSumaiya AjazSumaiya dismissed stale reviews from kmaschi and brasewel via e379a25 May 5, 2025 15:37
@AjazSumaiya AjazSumaiya merged commit 637fd8b into develop May 6, 2025
3 checks passed
@AjazSumaiya AjazSumaiya deleted the CEXT-4511 branch May 6, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants