Skip to content

feat(metadata): initialize dotenv and include API mesh environment variables#247

Merged
kmaschi merged 5 commits into
developfrom
bugfix/CEXT-4492-passthrough-api-mesh-env-headers
Apr 25, 2025
Merged

feat(metadata): initialize dotenv and include API mesh environment variables#247
kmaschi merged 5 commits into
developfrom
bugfix/CEXT-4492-passthrough-api-mesh-env-headers

Conversation

@kmaschi
Copy link
Copy Markdown
Member

@kmaschi kmaschi commented Apr 25, 2025

Description

API Mesh CLI plugin has no way to include custom headers required to identify traffic in certain environments. Change to source values from environment variables and default to constants for an environment when not present.

Related Issue

CEXT-4492

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

bhairavi25
bhairavi25 previously approved these changes Apr 25, 2025
@bhairavi25
Copy link
Copy Markdown
Collaborator

bhairavi25 commented Apr 25, 2025

We should consider whitelisting only the headers we explicitly intend to support, as a sanity check. This helps prevent unintentionally accepting too many headers, which could lead to more data sent in requests leading to latency.

@kmaschi kmaschi merged commit d3f99b1 into develop Apr 25, 2025
4 checks passed
@kmaschi kmaschi deleted the bugfix/CEXT-4492-passthrough-api-mesh-env-headers branch April 25, 2025 18:54
kmaschi added a commit that referenced this pull request Apr 28, 2025
* feat(metadata): initialize dotenv and include API mesh environment variables (#247)

* feat(metadata): initialize dotenv and include API mesh environment variables

* fix(helpers): reformat API mesh environment variable headers

* fix(helpers): improve header formatting for API mesh environment variables

* fix(helpers): improve header formatting for API mesh environment variables

* feat(constants): add dotenv support and export environment variables for API mesh

---------

Co-authored-by: Kristopher Maschi <kmaschi@adobe.com>

* Update package.json to 5.3.1

---------

Co-authored-by: Kristopher Maschi <kmaschi@adobe.com>
kmaschi added a commit that referenced this pull request Apr 28, 2025
* feat(metadata): initialize dotenv and include API mesh environment variables (#247)

* feat(metadata): initialize dotenv and include API mesh environment variables

* fix(helpers): reformat API mesh environment variable headers

* fix(helpers): improve header formatting for API mesh environment variables

* fix(helpers): improve header formatting for API mesh environment variables

* feat(constants): add dotenv support and export environment variables for API mesh

---------



* Update package.json to 5.3.1

---------

Co-authored-by: Brasewel Noronha <100383619+brasewel@users.noreply.github.com>
Co-authored-by: Kristopher Maschi <kmaschi@adobe.com>
kmaschi added a commit that referenced this pull request May 12, 2025
* feat: EOD commit, encyption of license key - WIP, need to fix tests

* feat: fixing failing test

* feat: bump alpha version

* feat: modiefied code to address review comment and address for splunk key as well

* feat: very minor correction

* feat(metadata): initialize dotenv and include API mesh environment variables (#247)

* feat(metadata): initialize dotenv and include API mesh environment variables

* fix(helpers): reformat API mesh environment variable headers

* fix(helpers): improve header formatting for API mesh environment variables

* fix(helpers): improve header formatting for API mesh environment variables

* feat(constants): add dotenv support and export environment variables for API mesh

---------

Co-authored-by: Kristopher Maschi <kmaschi@adobe.com>

* Release/5.3.1 (#248) (#249)

* feat(metadata): initialize dotenv and include API mesh environment variables (#247)

* feat(metadata): initialize dotenv and include API mesh environment variables

* fix(helpers): reformat API mesh environment variable headers

* fix(helpers): improve header formatting for API mesh environment variables

* fix(helpers): improve header formatting for API mesh environment variables

* feat(constants): add dotenv support and export environment variables for API mesh

---------



* Update package.json to 5.3.1

---------

Co-authored-by: Brasewel Noronha <100383619+brasewel@users.noreply.github.com>
Co-authored-by: Kristopher Maschi <kmaschi@adobe.com>

* refactor: removed Newrelic license 40 char restriction

* bump up package version

* fix: updated  keys to enum values

* Update package version

* Update package version

* Apply suggestions from code review

Co-authored-by: Brasewel Noronha <100383619+brasewel@users.noreply.github.com>

* fix: linting

* updated package version

---------

Co-authored-by: Narendra Vyas <nvyas@adobe.com>
Co-authored-by: Kris Maschi <kmasc072@gmail.com>
Co-authored-by: Kristopher Maschi <kmaschi@adobe.com>
Co-authored-by: Brasewel Noronha <100383619+brasewel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants