Skip to content

Add command to fetch log forwarding errors#259

Merged
AjazSumaiya merged 14 commits into
developfrom
cext-4177/log-forwarding-errors
Jun 3, 2025
Merged

Add command to fetch log forwarding errors#259
AjazSumaiya merged 14 commits into
developfrom
cext-4177/log-forwarding-errors

Conversation

@AjazSumaiya
Copy link
Copy Markdown
Contributor

@AjazSumaiya AjazSumaiya commented May 21, 2025

Description

Added log-forwarding errors command as sub command under get-log-forwarding

Description of config command
image

Description of delete:log-forwarding command is
image

Description of set:log-forwarding command is
image

Description of get:log-forwarding command is
image

Description of get-log-forwarding:errors command is
image

Output
image
image

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AjazSumaiya AjazSumaiya requested a review from jhadobe May 21, 2025 14:21
Comment thread src/commands/api-mesh/config/get/log-forwarding/errors.js Outdated
Comment thread src/commands/api-mesh/config/get/log-forwarding/errors.js Outdated
Comment thread src/commands/api-mesh/config/get/log-forwarding/errors.js Outdated
Comment thread src/commands/api-mesh/config/get/log-forwarding/errors.js Outdated
Comment thread src/commands/api-mesh/config/get/log-forwarding/errors.js Outdated
Comment thread src/commands/api-mesh/config/get/log-forwarding/errors.js Outdated
Comment thread src/lib/smsClient.js Outdated
Comment thread src/commands/api-mesh/config/get/log-forwarding/errors.js Outdated
Comment thread src/commands/api-mesh/config/get/log-forwarding/index.js Outdated
Comment thread src/commands/api-mesh/config/get/log-forwarding/index.js Outdated
AjazSumaiya and others added 2 commits May 22, 2025 14:35
Co-authored-by: Jared Hoover <98363870+jhadobe@users.noreply.github.com>
@AjazSumaiya AjazSumaiya marked this pull request as ready for review May 22, 2025 14:08
@AjazSumaiya AjazSumaiya requested a review from brasewel May 22, 2025 14:08
dani97
dani97 previously approved these changes May 22, 2025
Comment thread src/commands/api-mesh/config/get/log-forwarding/errors.js Outdated
Comment thread package.json
@brasewel
Copy link
Copy Markdown
Contributor

Looks good now, but can you update the PR with the updated screenshots of what the command looks like now? This will also be needed for @jhadobe

Copy link
Copy Markdown
Contributor

@brasewel brasewel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. @jhadobe we'll need to update the documentation based on this

@AjazSumaiya AjazSumaiya merged commit 3dcc4e2 into develop Jun 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants