Skip to content

Cext 5747 secrets validation#282

Merged
nvyasadobe merged 7 commits into
developfrom
CEXT-5747-secrets-validation
Mar 19, 2026
Merged

Cext 5747 secrets validation#282
nvyasadobe merged 7 commits into
developfrom
CEXT-5747-secrets-validation

Conversation

@nvyasadobe
Copy link
Copy Markdown
Contributor

Description

Adds validation on secrets count users can provide in secrets.yaml. Created a constant, current value is 25

Related Issue

https://jira.corp.adobe.com/browse/CEXT-5747

Motivation and Context

How Has This Been Tested?

Verified that the validation logic is working, by making a local link of CLI package.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvyasadobe nvyasadobe marked this pull request as ready for review March 19, 2026 12:30
kmaschi
kmaschi previously approved these changes Mar 19, 2026
Comment thread src/constants.js Outdated
DEV_CONSOLE_TRANSPORTER_API_KEY: 'UDPWeb1',
AIO_CLI_API_KEY: 'aio-cli-console-auth-stage',
SMS_BASE_URL: 'https://graph-stage.adobe.io/api-admin',
SMS_BASE_URL: 'https://graph-qa.adobe.io/api-admin',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be changed to qa in the commit?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have correct the same

kmaschi
kmaschi previously approved these changes Mar 19, 2026
@nvyasadobe nvyasadobe merged commit 7e546f6 into develop Mar 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants