Skip to content

Update workflows node version #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminkalk merged 11 commits into from
May 1, 2026
Merged

Update workflows node version #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4546d34
DINT-1889: update ACDL version
benjaminkalk Apr 14, 2026
37bd2a4
Update turbo config and use correct artifactory setup
benjaminkalk Apr 15, 2026
1b385d2
Add npmrc file
r48patel Apr 15, 2026
8b91386
update config and lock file for public consumption
benjaminkalk Apr 15, 2026
0856363
lint fix
benjaminkalk Apr 15, 2026
390fc6c
Update tests to mock structuredClone
benjaminkalk Apr 21, 2026
387da64
update node version
benjaminkalk Apr 29, 2026
0036c79
Merge branch 'main' into DINT-1889
benjaminkalk Apr 29, 2026
4e8e458
Update node versions in build workflows
benjaminkalk Apr 29, 2026
1b835b6
merge main
benjaminkalk Apr 29, 2026
4774efe
add node version to strategy
benjaminkalk Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/publish-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ jobs:
publish-latest:
name: publish-latest
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [lts/*]
steps:
- name: checkout
uses: actions/checkout@v2
Expand All @@ -24,11 +27,10 @@ jobs:
# path: "**/node_modules"
# key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

- name: node
uses: actions/setup-node@v2
- name: node ${{ matrix.node-version }}
Copy link
Copy Markdown

@devpatil7 devpatil7 Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminkalk Does this need following? I'm not sure which version would it run when we dont specify anything.

strategy:
matrix:
node-version: [22]

Copy link
Copy Markdown
Contributor Author

@benjaminkalk benjaminkalk Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @devpatil7, I have added strategy with latest version to align with the PR workflow.

uses: actions/setup-node@v4
with:
node-version: 16
registry-url: https://registry.npmjs.org/
node-version: ${{ matrix.node-version }}

- name: install
run: yarn install --frozen-lockfile
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/storefront-merge-to-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ jobs:
storefront-merge-to-main:
name: storefront-merge-to-main
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [lts/*]
steps:
- name: checkout
uses: actions/checkout@v2
Expand All @@ -24,11 +27,10 @@ jobs:
path: "**/node_modules"
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

- name: node
uses: actions/setup-node@v2
- name: node ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: 18
registry-url: https://registry.npmjs.org/
node-version: ${{ matrix.node-version }}

- name: install
run: yarn install --frozen-lockfile
Expand Down
Loading