SITES-41121 Screen reader announces component name and an invisible group name#406
Merged
StoianLucian merged 1 commit intoadobe:masterfrom Mar 17, 2026
Merged
Conversation
Contributor
Author
|
This PR makes all keyboard accessible tags not accessible in order to prevent being focusable with TAB key when parent item is not focused |
surajmall
suggested changes
Mar 6, 2026
| if (element instanceof HTMLElement) { | ||
| element.setAttribute("tabindex", value); | ||
| const el = element.querySelectorAll("button:not([hidden])"); | ||
| const buttonArray = Array.from(el).filter(item => item.offsetParent); |
There was a problem hiding this comment.
do we use “offsetParent === null” as “treat as hidden / skip.”? are we sure that if offsetParent is null, does it means hidden?
Contributor
Author
There was a problem hiding this comment.
It's basically the same logic as the one on line 205 (this.items._getSelectableItems().filter(item => !item.hasAttribute('hidden') && item.offsetParent);)
filter(el => el.offsetParent) = elements that are display:none, or in our case, which are hidden
surajmall
approved these changes
Mar 17, 2026
|
🎉 This PR is included in version 4.21.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JIRA Ticket: https://jira.corp.adobe.com/browse/SITES-41121
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Before the fix:
Screen.Recording.2026-02-27.at.13.55.28.mov
After the fix:
Screen.Recording.2026-02-27.at.13.45.15.mov
Types of changes
Checklist: