fix: guard against null body in notifyCollab to prevent move partial_failure - #267
Merged
Merged
Conversation
…failure notifyCollab called resp.body.cancel() unconditionally. When the collab service returns a bodyless response, this threw TypeError in the finally block of copyFile, cancelling the successful copy return value and causing moves to fail with partial_failure 500 — leaving files duplicated at both source and destination instead of being renamed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
🎉 This PR is included in version 1.6.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifyCollab(used bycopyFile) calledresp.body.cancel()with no null guardTypeError: Cannot read properties of null (reading 'cancel')inside thefinallyblock ofcopyFilefinallyexceptions replace the return value, the successful S3CopyObjectCommandresult was discarded —deleteObjectwas never called, leaving files duplicated at both source and destinationpartial_failure500 instead of 204Fix:
resp.body?.cancel()— one character, safe for all cases including undefined.This bug was revealed by PR #266 (move error logging), which made previously silent
partial_failure500s visible in Cloudflare Worker logs.Test plan
does not throw when collab response has null bodyintest/storage/utils/object.test.jsnotifyCollabtests still pass🤖 Generated with Claude Code