fix: buffer current.body to ArrayBuffer before putVersion to survive SDK retries - #268
Merged
Merged
Conversation
…SDK retries putVersion passes current.body (a ReadableStream from getObject) to PutObjectCommand. The AWS SDK retries on network failures with the same stream — but a ReadableStream can only be consumed once. Cloudflare throws "An error was encountered in a non-retryable streaming request." on the retry, causing putVersion to fail and postObjectVersionWithLabel to return 500 instead of 201. Seen in production on /versionsource/ endpoints. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
🎉 This PR is included in version 1.6.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
putVersionreceivedcurrent.body(a live R2ReadableStreamfromgetObject) as theBodyofPutObjectCommandReadableStreamcan only be consumed once"An error was encountered in a non-retryable streaming request.", causingputVersionto return 500 andpostObjectVersionWithLabelto return 500 instead of 201/versionsource/500 errors on the new script version after PR fix: consumed body on retry #264 was deployed (PR fix: consumed body on retry #264 fixedupdate.bodybut notcurrent.body)Fix: buffer
current.bodytoArrayBufferimmediately aftergetObjectinputObjectWithVersion, before it is passed toputVersion. AnArrayBuffercan be reused freely across retries.Test plan
returns 201 when version client body is a ReadableStream that would be disturbed by SDK retry— mockifNoneMatchclient throws if it receives aReadableStream, passes withArrayBuffer🤖 Generated with Claude Code