feat(edit): loading spinner for pages and sheets - #1147
Open
markdaugherty wants to merge 9 commits into
Open
Conversation
Pages previously rendered an empty editor until content loaded. Add a centered spinner (reusing the shared .da-loading-spinner pattern) that shows in the page editor until the document has synced and rendered, and in the sheet view until data is fetched and the grid is rendered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a da-content test that mounts the component and asserts the loading spinner shows until contentReady is set, and extend the prose initProse sync test to assert contentReady is set once the WebSocket syncs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
markdaugherty
marked this pull request as ready for review
July 17, 2026 21:48
Contributor
|
@markdaugherty can you have a look at the failing e2e tests |
| if (pm) pm.contentEditable = 'true'; | ||
| } | ||
| // Content has synced and rendered — clear the loading spinner. | ||
| if (daContent) daContent.contentReady = true; |
Contributor
There was a problem hiding this comment.
Shouldn't this be reset on nav as well? Currently the spinner appears only on the very first /edit -> all subsequent pages still have the previous behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a centered loading spinner to the page editor and the sheet view while their content loads. For pages, the spinner shows until the document has synced over the collab WebSocket and rendered (gated on a new
contentReadyflag set fromonWsSync), not merely when the empty editor mounts. For sheets, it shows while data is fetched and the grid is rendered. Reuses the existing.da-loading-spinnervisual style.Why
Pages and sheets previously rendered an empty area until content finished loading, with no indication anything was happening.
Reviewer notes
syncedsignal already used to enable editing, so content and spinner-removal stay in sync..da-loading-spinner/@keyframes da-spinare redefined locally inda-content.cssandsheet.css(sized up to 32px) rather than importingshared/styles/base.css, since neither view adopts that sheet.contentReadyon sync).