fix(focal-point): load block library via schema-free shared loader - #1277
Open
usman-khalid wants to merge 3 commits into
Open
fix(focal-point): load block library via schema-free shared loader#1277usman-khalid wants to merge 3 commits into
usman-khalid wants to merge 3 commits into
Conversation
imageFocalPoint runs in both the edit and canvas editors, but it read the block library through the edit-side da-library loader, whose eager HTML parsing reads window.view.state.schema. In the canvas editor window.view is undefined, so the focal-point icon failed to initialize. Extract the canvas block-library loader (which stores raw DOM and needs no schema) into blocks/shared/block-library.js and point imageFocalPoint at it. Canvas call sites now import from shared; the canvas-only AEM Assets plugin injection stays in canvas and is layered on in getCanvasToolPanelViews. The shared module sources config helpers from blocks/shared/utils.js, dropping the nx dependency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
usman-khalid
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing back @hannessolo's work from #1155 which got closed by accident due to a branch naming conflict.