feat(ew): add viewport switcher for block library modal and increase modal size - #1278
Open
usman-khalid wants to merge 3 commits into
Open
feat(ew): add viewport switcher for block library modal and increase modal size#1278usman-khalid wants to merge 3 commits into
usman-khalid wants to merge 3 commits into
Conversation
usman-khalid
requested review from
amol-anand,
hannessolo,
mhaack and
sharanyavinod
August 26, 2026 22:48
Contributor
|
shouldn't we also support viewport switching layout view #1129? can obv be a separate/follow up PR, but giving that in library without it in layout view seems like a logical disconnect. |
Contributor
Author
Yup, that can be a follow-up IMO, but if we don't want to get this in without it, I'm fine to wait until we have something for #1129 or I can add it to this PR when I have some time. |
Contributor
|
@usman-khalid @shsteimer #1129 should be a separate PR. We are still discussing if we even should do it or not. From UE analytics we know this feature is not really used by customers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1209
Plus adds a switcher so authors can see how blocks look in each viewport while selecting one from the library.