Conversation
details.fullpath still carries the .html suffix added by getPathDetails, but /canvas expects the extensionless path used elsewhere (e.g. getEditPath in blocks/browse/shared.js). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
sharanyavinod
approved these changes
Sep 4, 2026
rofe
approved these changes
Sep 4, 2026
1 task
mhaack
added a commit
that referenced
this pull request
Sep 7, 2026
* test(e2e): add Experience Workspace user toggle coverage Covers the /edit <-> /canvas redirect behavior (#1289, #1290, #1299): first-time toggle-on shows the welcome dialog and sets the nx2:ew-user-enabled flag, /edit keeps redirecting to /canvas while the flag is set, and toggling off in the profile menu clears the flag and stops the redirect. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix: remove ew check as it - testing * fix: re-add --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blocks/edit/edit.jsredirects/editto/canvaswhen Experience Workspace is enabled (introduced in fix: redirect /edit to /canvas when Experience Workspace is enabled #1290), but useddetails.fullpathas-is, which still carries the.htmlsuffix added bygetPathDetails..htmlsuffix before building the/canvas#...hash, matching the extensionless-path convention used elsewhere (e.g.getEditPathinblocks/browse/shared.js, and the same regex already used a few lines below in this file).Test plan
/edit#/org/site/page, confirm redirect lands on/canvas#/org/site/page(no.htmlin the hash)