feat(ew): add theme toggle to profile menu - #566
Closed
usman-khalid wants to merge 2 commits into
Closed
Conversation
Contributor
|
As discussed on Friday, we will post-pone this until we have full dark mode support on all screens. |
|
Checking in on this PR. It has been quiet for a while, so we have labeled it |
Contributor
Author
|
Closing this until we need the toggle, which might be a while. Dark mode is not properly supported everywhere in EW yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should wait until dark mode is fully supported everywhere. Currently pinned to light mode: adobe/da-live#1060
SITES-45379