feat: add loading spinners to translate view action buttons - #709
Draft
markdaugherty wants to merge 2 commits into
Draft
feat: add loading spinners to translate view action buttons#709markdaugherty wants to merge 2 commits into
markdaugherty wants to merge 2 commits into
Conversation
Every async action button (Connect, Get status, Translate all, Cancel project, Copy all, per-language Cancel) now disables and shows a spinner while its handler is in flight, instead of giving no feedback during the request. Reuses/combines the two spinner patterns already in the repo rather than adding a third: the .nx-loading-spinner/da-spin naming from nx2/styles/buttons.css (defined but never wired to anything) with the currentcolor border technique from ew-actions.js's spinner, needed since these buttons render with different text colors per variant. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit 2b29434)
# Conflicts: # nx/blocks/loc/views/translate/translate.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary