fix(translate): fix Trados translation-status detection bugs - #718
Draft
markdaugherty wants to merge 8 commits into
Draft
fix(translate): fix Trados translation-status detection bugs#718markdaugherty wants to merge 8 commits into
markdaugherty wants to merge 8 commits into
Conversation
getStatusAll unconditionally overwrote lang.translation.status from Trados's task list, with no guard against an already-'complete' status. Trados keeps reporting completed file-delivery tasks indefinitely, so every subsequent "Get status" click reverted a 'complete' lang back to 'translated', causing checkAndSaveLangs to re-download and re-save it every time. Fixed by treating 'complete' and 'cancelled' as terminal, mirroring the equivalent Smartling fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…nector-fixes # Conflicts: # WORKLOG.md
- getLangStatus now considers a language done once none of its tasks are left in a non-terminal status, instead of requiring a 'file-delivery' task specifically - some project templates (e.g. TM-leverage-only workflows) never create that task type, leaving languages stuck at "in progress" in DA even though Trados has finished them - Add pagination to the tasks fetch (fetchAllTasks) - it only returned the first 100 tasks per project, silently undercounting completed work on larger projects - Verified against a real affected project (via a throwaway smoke test, not committed): all 5 languages now resolve to "translated" Co-Authored-By: Claude <noreply@anthropic.com>
… into trados-connector-fixes
markdaugherty
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
complete/cancelledwhen polling status, so Trados's indefinitely-reported completed tasks no longer trigger a re-save or un-cancelfile-deliverytask specifically — some project templates (e.g. TM-leverage-only workflows) never create that task type, leaving finished languages stuck at "in progress" in DAtranslatedFull test suite (105 files) passes locally.