Conversation
PR #716 scoped daFetch's permissions fallback to resp.ok, which also suppressed it on 404s. A 404 from source.get on a brand-new/unsaved doc means nothing exists there yet, not that access was denied, so it should still get the fallback. Real auth failures (401/403) and other errors continue to get no fabricated permissions. This unblocks da-live's sheet block, which was leaving da-title's permissions undefined for a new sheet and hiding da-sheet-tabs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
anfibiacreativa
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daFetch's permissions fallback toresp.ok, which also suppressed it on 404s.source.geton a brand-new/unsaved doc means nothing exists there yet, not that access was denied, so it should still get the read/write fallback. Real auth failures (401/403) and other error statuses continue to get no fabricated permissions.da-title.permissionsundefinedfor a new sheet and hidingda-sheet-tabs(failing the "New sheet" e2e test).Test plan
npx wtrontest/nx2/utils/api.test.js— 123 passednpm test(full suite) — 1769 passed, 0 failed, 3 skipped