Skip to content

build(deps-dev): bump chromedriver from 146.0.5 to 146.0.6 - #591

Open
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/chromedriver-146.0.6
Open

build(deps-dev): bump chromedriver from 146.0.5 to 146.0.6#591
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/chromedriver-146.0.6

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps chromedriver from 146.0.5 to 146.0.6.

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 24, 2026
@github-actions github-actions Bot mentioned this pull request Aug 24, 2026
Open
@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Agent QA review — interactive + visual diff (advisory, non-blocking)

Last updated Sep 4, 2026, 3:07 AM PDT · new commit pushed · commit ba67f08 · 2 files changed.

0 open · 0 resolved · visual diff 0.00% · verdict PASS

Open findings

  • Smoke test passed ✅
What the agent checked

Tested PR #591 on https://business.adobe.com/resources/main.html with the PR's CaaS build injected.

Context: This PR only bumps the chromedriver devDependency (146.0.5 → 146.0.6) used for local/CI Selenium testing. It touches only package.json/package-lock.json — no application/runtime source files. Consistent with that, the pixel-diff of PR build vs stable build showed 0.00% changed pixels, and loading the diff.png overlay showed no magenta/highlighted regions anywhere on the page — i.e. the tool found literally nothing that changed visually.

Manual QA performed on the live page to confirm nothing regressed:

  1. Initial page load (business.adobe.com/resources/main.html) — renders normally, header, hero, and CaaS "Explore all Adobe resources" grid all display correctly.
  2. Left filter panel ("Refine Your Results") — Products/Content type/Industry accordions expand/collapse correctly.
  3. Applied the "Acrobat" checkbox filter under Products — result count updated correctly from 3877 → 193, an "Acrobat ×" filter chip appeared, checkbox state and count badge (1) updated correctly, and the card grid re-rendered with Acrobat-related content (thumbnails, titles, descriptions, CTA buttons all intact, no layout breakage).
  4. Unchecked the filter — reverted cleanly.
  5. run_axe on the filter panel: 0 violations, 22 passes, 0 incomplete.
  6. get_console_errors: no console errors observed during load or interaction.

No visual, functional, accessibility, or console issues found. Card layout, filter panel, chip/badge behavior, and result counts all work as expected. This is exactly what's expected for a pure dev-tooling dependency bump with no production code changes — the PR is safe and introduces no regressions to the live CaaS collection page.

PR / stable / diff screenshots + console + axe artifacts in the workflow run.

Review history (3 runs)
  • ba67f08 · Sep 4, 2026, 3:07 AM PDT · new commit pushed · passing, no regressions — Merge branch 'main' into dependabot/npm_and_yarn/chromedrive
  • a0fe1ef · Aug 26, 2026, 11:00 PM PDT · new commit pushed · passing, no regressions — build(deps-dev): bump chromedriver from 146.0.5 to 146.0.6
  • feede48 · Aug 26, 2026, 1:12 AM PDT · new commit pushed · passing, no regressions — Merge branch 'main' into dependabot/npm_and_yarn/chromedrive

@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

AI Code Review

Last updated Sep 4, 2026 2:36 AM PDT · new commit pushed · commit ba67f08 · 2 files changed in PR.

0 open · 0 resolved

Open findings

No open findings. ✅

Review history (2 runs)
  • ba67f08 · Sep 4, 2026 2:36 AM PDT · new commit pushed · no changes (0 open) — Merge branch 'main' into dependabot/npm_and_yarn/chromedriver-146.0.6
  • feede48 · Aug 26, 2026 1:14 AM PDT · new commit pushed · no changes (0 open) — Merge branch 'main' into dependabot/npm_and_yarn/chromedriver-146.0.6

@raissanjay raissanjay mentioned this pull request Aug 26, 2026
Closed
sanrai added a commit that referenced this pull request Aug 26, 2026
@sanrai
fix(mwpw-184989): send x-session-id to the LLM proxy and stop Feature…
69f4658 
… QA failing silently

The proxy now rejects requests without x-session-id (HTTP 403 missing_required_header). Only qa-runner-v2.mjs sent it, so Agent QA Review kept working while every direct caller started 403ing.

On PR #591 that killed feature-review.mjs at its first LLM call: three 403s, llm failed after retries, and the top-level catch exited 0. Green job, no comment - even though build-output-diff had already published NO_CHANGE and review-score-gate had auto-passed the PR.

- add x-session-id to all eight direct proxy callers

- feature-review.mjs: fall back to postNonInjectable when the triage model is unavailable, so the deterministic bundle-diff verdict is still reported (it is a REST status read, it never needed a model)

- feature-review.mjs: write FEATURE_REVIEW_FAILED on an unhandled error

- qa-feature-review.yml: log that marker to the shared monitor issue, mirroring qa-agent-review.yml, so a silent outage is visible

Claude-Session: https://claude.ai/code/session_01QimdQaYPSvXAaSDAssrfK1
@sanrai sanrai mentioned this pull request Aug 26, 2026
Merged
sanrai added a commit that referenced this pull request Aug 27, 2026
@sanrai @sr8384856
fix(mwpw-184989): send x-session-id to the LLM proxy and stop Feature…
faaa4fd 
… QA failing silently (#600)

* fix(mwpw-184989): send x-session-id to the LLM proxy and stop Feature QA failing silently

The proxy now rejects requests without x-session-id (HTTP 403 missing_required_header). Only qa-runner-v2.mjs sent it, so Agent QA Review kept working while every direct caller started 403ing.

On PR #591 that killed feature-review.mjs at its first LLM call: three 403s, llm failed after retries, and the top-level catch exited 0. Green job, no comment - even though build-output-diff had already published NO_CHANGE and review-score-gate had auto-passed the PR.

- add x-session-id to all eight direct proxy callers

- feature-review.mjs: fall back to postNonInjectable when the triage model is unavailable, so the deterministic bundle-diff verdict is still reported (it is a REST status read, it never needed a model)

- feature-review.mjs: write FEATURE_REVIEW_FAILED on an unhandled error

- qa-feature-review.yml: log that marker to the shared monitor issue, mirroring qa-agent-review.yml, so a silent outage is visible

Claude-Session: https://claude.ai/code/session_01QimdQaYPSvXAaSDAssrfK1

* fix(mwpw-184989): send slicc version to LLM proxy

---------

Co-authored-by: Sanjay Rai <10876964+sanrai@users.noreply.github.com>
Co-authored-by: sr8384856 <sr8384856@gmail.com>
@sanrai

sanrai commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

@dependabot rebase

@dependabot @github

dependabot Bot commented on behalf of github Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@sanrai

sanrai commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

@dependabot recreate

@dependabot
build(deps-dev): bump chromedriver from 146.0.5 to 146.0.6
a0fe1ef 
Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 146.0.5 to 146.0.6.
- [Commits](giggio/node-chromedriver@146.0.5...146.0.6)

---
updated-dependencies:
- dependency-name: chromedriver
  dependency-version: 146.0.6
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/chromedriver-146.0.6 branch from 343c2b6 to a0fe1ef Compare August 27, 2026 05:45
@sonarqube-acom-pr-deco-public

sonarqube-acom-pr-deco-public Bot commented Aug 27, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: adobecom_caas_9e89bc21-de4f-46e2-9443-2052ced9386d

View in SonarQube

@github-actions

github-actions Bot commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

🧪 Feature QA review — injected feature test (advisory, non-blocking)

Last updated Sep 4, 2026, 2:51 AM PT · commit 904c1d1 · pull_request.

Overall: SAFE (no bundle change)

No injectable feature to exercise — and the deterministic build-output-diff proves the shipped bundle is byte-identical to base after normalization, so this change is safe for what ships.

This PR is a dev-dependency version bump (chromedriver) with no config/card-data-driven UI behavior to exercise.

Screenshot in the workflow run.

Review history (2 runs)
  • Sep 4, 2026, 2:51 AM PT · SAFE (no bundle change) · 904c1d1 · pull_request
  • Aug 26, 2026, 10:57 PM PT · SAFE (no bundle change) · 656cd4f · pull_request

@sanrai sanrai mentioned this pull request Aug 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sanrai