-
Notifications
You must be signed in to change notification settings - Fork 66
MWPW-186525 Lingo Query Index for Plans and Catalog #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3955,3 +3955,58 @@ indices: | |
| include: | ||
| - /cis_ru/cc-shared/fragments/merch/**/merch-card/** | ||
| target: /cis_ru/cc-shared/assets/query-index-cards.xslx | ||
|
|
||
| lingo-mapping-ca_fr: | ||
| target: /ca_fr/creativecloud/plans/merch-shared/assets/lingo/query-index.xslx | ||
| include: | ||
| - /ca_fr/creativecloud/plans | ||
| - /ca_fr/creativecloud/plans/** | ||
| - /ca_fr/products/catalog | ||
| - /ca_fr/products/catalog/** | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fragments need to be part of the Lingo query-index. Are the fragments used by these pages also under these paths?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sukamat Yes, shared assets and fragments are copied |
||
| exclude: | ||
| - "**/drafts/**" | ||
| - "**/*.json" | ||
|
|
||
| lingo-mapping-be_fr: | ||
| target: /be_fr/creativecloud/plans/merch-shared/assets/lingo/query-index.xslx | ||
| include: | ||
| - /be_fr/creativecloud/plans | ||
| - /be_fr/creativecloud/plans/** | ||
| - /be_fr/products/catalog | ||
| - /be_fr/products/catalog/** | ||
| exclude: | ||
| - "**/drafts/**" | ||
| - "**/*.json" | ||
|
|
||
| lingo-mapping-lu_fr: | ||
| target: /lu_fr/creativecloud/plans/merch-shared/assets/lingo/query-index.xslx | ||
| include: | ||
| - /lu_fr/creativecloud/plans | ||
| - /lu_fr/creativecloud/plans/** | ||
| - /lu_fr/products/catalog | ||
| - /lu_fr/products/catalog/** | ||
| exclude: | ||
| - "**/drafts/**" | ||
| - "**/*.json" | ||
|
|
||
| lingo-mapping-ch_fr: | ||
| target: /ch_fr/creativecloud/plans/merch-shared/assets/lingo/query-index.xslx | ||
| include: | ||
| - /ch_fr/creativecloud/plans | ||
| - /ch_fr/creativecloud/plans/** | ||
| - /ch_fr/products/catalog | ||
| - /ch_fr/products/catalog/** | ||
| exclude: | ||
| - "**/drafts/**" | ||
| - "**/*.json" | ||
|
|
||
| lingo-mapping-fr: | ||
| target: /fr/creativecloud/plans/merch-shared/assets/lingo/query-index.xslx | ||
| include: | ||
| - /fr/creativecloud/plans | ||
| - /fr/creativecloud/plans/** | ||
| - /fr/products/catalog | ||
| - /fr/products/catalog/** | ||
| exclude: | ||
| - "**/drafts/**" | ||
| - "**/*.json" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/creativecloud/plans..appears to store index for both/ca_fr/creativecloud/plansand/ca_fr/products/catalogpathsUsually the index are placed in at root
e.g. /cc-shared/assetsshould a similar be usede.g. /merch-shared/assets/be usedcc: @nkthakur48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raga-adbe-gh The shared folder will be
creativecloud/plans/merch-sharedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is the way that lingo is built, it expects one primary query index for lingo per locale per project. The query indexes also have to live at a specific path like @raga-adbe-gh called out, because that contract makes link localization faster.
For now can we have these pages live in /cc-shared/assets/lingo until upp is ready to have its own query index?