MWPW-180247: Fix prompt-card equal-height alignment across mixed title lengths - #198
Open
DavidKHahn wants to merge 1 commit into
Open
MWPW-180247: Fix prompt-card equal-height alignment across mixed title lengths#198DavidKHahn wants to merge 1 commit into
DavidKHahn wants to merge 1 commit into
Conversation
The block's flex layout was inert (display: flow instead of flex), so cards with different title line-counts in the same grid row rendered at different heights, misaligning the Copy button row (MWPW-180247). Also fixes a box-sizing gap that would have inflated every card's height regardless of content.
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stage #198 +/- ##
==========================================
+ Coverage 77.18% 78.01% +0.83%
==========================================
Files 47 47
Lines 11554 11554
==========================================
+ Hits 8918 9014 +96
+ Misses 2636 2540 -96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DavidKHahn
marked this pull request as ready for review
September 4, 2026 22:49
DavidKHahn
requested review from
KetakiD-Deshwandikar,
Ruchika4,
markovicpredrag1209 and
maxn-adobe
September 4, 2026 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
study-marqueesibling blockprompt-cardhad an inert flex layout (display: flowinstead offlex), so cards with different title line-counts in the same grid row rendered at different heights, misaligning the "Copy" button row (e.g. visible on/ar/acrobat/generative-ai-pdf/ai-prompts.html).prompt-card/.prompt-blade/.prompt-copy/.prompt-copy-btn-wrapperso cards stretch to equal height, the grey prompt-preview box grows to fill available space (with a safe minimum so long content still line-clamps correctly), and the CTA row aligns consistentlybox-sizinggap that would have inflated every card's height by ~42px regardless of content lengthBefore / After
TEST URLS (QA):
Before (prod):
https://www.adobe.com/ar/acrobat/generative-ai-pdf/ai-prompts.html
https://www.adobe.com/acrobat/online/ai-chat-pdf
https://www.adobe.com/acrobat/online/ai-summary-generator
https://www.adobe.com/acrobat/generative-ai-pdf/students
After (branch preview):
https://mwpw-180247--da-dc--adobecom.aem.page/ar/acrobat/generative-ai-pdf/ai-prompts
https://mwpw-180247--da-dc--adobecom.aem.page/acrobat/online/ai-chat-pdf
https://mwpw-180247--da-dc--adobecom.aem.page/acrobat/online/ai-summary-generator
https://mwpw-180247--da-dc--adobecom.aem.page/acrobat/generative-ai-pdf/students
Test plan
ai-chat-pdf,ai-summary-generator) render pixel-identical before/after — no regressiontest/blocks/prompt-card/*.test.js(18/18)Known follow-up (not in this PR)
acrobat/scripts/mep/dc1052/prompt-card/prompt-card.cssis a separate MEP-experiment copy of this file that still has the original bug. Left untouched pending confirmation on whether that experiment is still active.