Call section-columns layout unconditionally for static pages - #52
Open
qiyundai wants to merge 3 commits into
Open
Call section-columns layout unconditionally for static pages#52qiyundai wants to merge 3 commits into
qiyundai wants to merge 3 commits into
Conversation
event-libs now exports applySectionColumnsLayout and addStylesToEventPage publicly instead of running them only inside decorateEvent, which is gated behind event-id and never runs on static/non-event pages. da-events calls both directly in its own decorateArea, above the event-id gate, so pages using `section-layout: columns` page metadata get the flex-column layout regardless of whether they're event pages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
event-libs' applySectionColumnsLayout() is now exported publicly and loads its own required CSS, since decorateEvent (which used to call it internally) is gated behind event-id and never runs on static pages. da-events' own decorateArea calls it directly, unconditionally, above that gate, so pages using `section-layout: columns` page metadata get the flex-column layout regardless of whether they're event pages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
sharmeebuilds
approved these changes
Aug 18, 2026
Comment on lines
+67
to
+69
| // Runs unconditionally (unlike decorateEvent below) since section-layout | ||
| // is meant for static/non-event pages too, not just pages with an event-id. | ||
| // Loads its own required CSS internally. |
Collaborator
There was a problem hiding this comment.
comments can be removed
…se comments The applyPageBackground destructured import hit a merge conflict from a stash pop against the existing applySectionColumnsLayout wiring - resolved by keeping both. Added the missing applyPageBackground() call in loadPage() alongside applySectionColumnsLayout(), both after await loadArea() so Milo's .section class exists by the time they run. Also strips all non-license-header, non-functional comments per byte-size preference for this unbundled, unminified library (kept the eslint-disable-next-line on the dapreview dynamic import, since that one is functional, not documentation). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No activity in 7 days. Will be labeled No activity in 14 days, labeled Rundeck job Git Stale PR Check (git-stale-pr-bot), execution 2739336, project global, run by casalino |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
No ticket — follow-up to event-libs' opt-in flex-column section layout feature.
Summary
event-libs added
applySectionColumnsLayout(): page metadatasection-layout: columnsmakes a page's<main>a flex row of its.sectionchildren (columns), with blocks still stacking normally inside each column. It's exported publicly (not called fromdecorateEvent) becausedecorateEventonly runs on pages withevent-id— and this repo's owndecorateAreaonly callsdecorateEventafter that same gate, so the feature would never reach static/non-event pages otherwise.This PR imports
applySectionColumnsLayoutfrom event-libs'libs.jsand calls it directly, unconditionally, in this repo'sdecorateArea(), above theevent-idgate — so both event and static pages get the layout when authored. It loads its own required CSS internally, so no other wiring is needed here.Companion PR in event-libs: adobecom/event-libs#232
Test plan
npm run lint— clean (pre-existing errors in unrelated files:registration-cache.js,tools/ms-apps/daUtils.js)npm test— 46/46 passing/code-review(high effort) — no critical/blocking findings; call placement, timing relative to Milo'ssetConfig/DOM readiness, and idempotency under fragment/personalization re-entry were all verified against actual Milo and event-libs sourcesection-layout: columnsmetadata and 2-3 sections; confirm side-by-side columns above 900px and normal stacking below it