MWPW-206340: Fix RSVP terms cell dropping bullets and running paragraphs together - #322
Open
qiyundai wants to merge 3 commits into
Open
MWPW-206340: Fix RSVP terms cell dropping bullets and running paragraphs together#322qiyundai wants to merge 3 commits into
qiyundai wants to merge 3 commits into
Conversation
…phs together addTerms() deleted every authored <li> outright instead of preserving it (a vestige of an old consent-checkbox mechanism now fully superseded by the JSON/country-index-driven consent suite), and .event-terms-wrapper had no vertical-stacking layout, so authored <p> paragraphs rendered side-by-side on one line instead of stacking. Move <p>/<ul>/<ol> together in document order (scoped to the cell's direct children, so a <p> nested inside a <li> stays inside its list item) instead of separately stripping <li>, and reuse the existing field-group-wrapper column-layout class instead of duplicating it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
michaelready
approved these changes
Sep 4, 2026
michaelready
self-requested a review
September 4, 2026 23:50
Real block markup nests authored p/ul/ol one level deeper (row > cell) than addTerms accounted for, so the previous :scope selector matched nothing and the whole terms row was deleted on production pages.
michaelready
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MWPW-206340: the events-form RSVP terms/description cell had two rendering bugs reported by QA.
addTerms()deleted every authored<li>outright instead of preserving it — a leftover from an old consent-checkbox mechanism (each<li>used to become a checkbox) that's since been fully replaced by the JSON/country-index-driven consent suite (addConsentSuite/loadConsent, a separate DOM subtree unrelated to this cell)..event-terms-wrapperhad no vertical-stacking layout, so authored<p>paragraphs rendered side-by-side on one line instead of stacking.Changes
addTerms()now moves the cell's direct<p>/<ul>/<ol>children into the wrapper together, in document order, instead of separately stripping<li>. Scoped to direct children (:scope >) so a<p>nested inside a<li>(common from rich-text paste) stays inside its list item rather than being pulled out as a stray sibling.field-group-wrappercolumn-layout class instead of adding a duplicate CSS rule, and added minimalul/olbullet spacing using the file's existing--spacing-*tokens.describe('addTerms', ...)covering bullet preservation, authoring-order variations, and the nested-<p>-in-<li>case.Test plan
npm run lintpasses cleannpx wtr test/unit/blocks/events-form/events-form.test.js --node-resolve --port=2000— couldn't get a clean run in the dev sandbox (headless Chrome can't reach the CDN-hosted Milo module the test harness depends on, reproducible on unmodifieddevtoo); please confirm green in CI/local