Conversation
qiyundai
left a comment
qiyundai
left a comment
There was a problem hiding this comment.
LGTM in general. Approved with some non-blocking comments
| 'aria-label': 'Close overlay', | ||
| src: '/events/blocks/adobe-connect/asset/Cross.svg', | ||
| alt: 'Close overlay', | ||
| }, |
There was a problem hiding this comment.
Let's also add role and tabindex attribute for this.
Alternatively, you might consider actually wrapping this img in a button element. You may also consider moving the svg files to the icons folder and use getIcon to summon the icon into your button's inner html, but this works just fine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #370 +/- ##
======================================
Coverage ? 69.00%
======================================
Files ? 24
Lines ? 5056
Branches ? 0
======================================
Hits ? 3489
Misses ? 1567
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (isTargetEmpty(targetVal) || shouldOverwrite) { | ||
| targetObject[key] = sourceVal; |
Check warning
Code scanning / CodeQL
Prototype-polluting function Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the prototype pollution vulnerability, we need to prevent the function from copying dangerous property names such as __proto__ and constructor from thisObject to targetObject. The best way to do this is to add a check inside the loop over Object.keys(thisObject) that skips any key that is "__proto__" or "constructor". This should be done in the function crawlAndUpdateObject in file rs/360-KCI-804/images/mktoTestFormConfig.js, specifically in the loop starting at line 857. No new methods or imports are required; a simple conditional check will suffice.
| @@ -855,6 +855,10 @@ | ||
| const isObjectLike = (value) => typeof value === 'object' && value !== null; | ||
|
|
||
| for (const key of Object.keys(thisObject)) { | ||
| // Prevent prototype pollution | ||
| if (key === "__proto__" || key === "constructor") { | ||
| continue; | ||
| } | ||
| if (!Object.prototype.hasOwnProperty.call(targetObject, key) && !addToTarget) { | ||
| continue; | ||
| } |
| el.setAttribute('data-mcz-dl-status', 'loading'); | ||
|
|
||
| let mczId = null; | ||
| if (getMetadata('eventExternalId')) { |
There was a problem hiding this comment.
The column currently in the metadata sheet is called 'external-event-id'. Your code is looking for eventExternalId. Is this intended? Are you planning on using the existing column or adding a new column? Also, I think generally we don't have camelCase metadata.
adobecom-git-stale-pr-bot
Bot
added
stale
|
No activity in 7 days. Will be labeled No activity in 14 days, labeled No activity in 21 days, labeled No activity in 28 days. Would normally close now, but auto-close is disabled this run. Add Rundeck job Git Stale PR Check (git-stale-pr-bot), execution 2739336, project global, run by casalino |
5 participants
Describe your specific features or fixes and provide a preview link for the feature being incorporated
Requires : Branch class-tf changes to be merged.
Note:
mktoTestFormConfig.js is a temp file which is being worked upon by rob leslie and would be removed most likely. please igonre it for your review.
Pending:
Associating externalEventID from events to mcz form. Requires updated files from rob leslie.
UTs
Resolves: MWPW-176011
Test URLs:
sample webinar page.
https://mkto-poc--events-milo--adobecom.aem.page/events/experience-makers-connect-poc/test-event-210725/2025-07-31?preview=1
To test the feature, please load up the branch locally and run it against your local ESP and ESL server.
For more information on how to set up ESL and ESP locally, please refer to: FE Dev Wiki