Skip to content

Nala: resolve WebKit timing issue in grid-marquee - #758

Open
yeibercano wants to merge 2 commits into
stagefrom
nala-grid-marquee
Open

Nala: resolve WebKit timing issue in grid-marquee #758
yeibercano wants to merge 2 commits into
stagefrom
nala-grid-marquee

Conversation

@yeibercano

@yeibercano yeibercano commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Summary

Fix tests by adding networkidle wait and increased timeout.

Potentially introduced here: #693


Jira Ticket

Resolves: MWPW-181665


Test URLs

Env URL
Before https://main--express-milo--adobecom.aem.page/express/
After https://nala-grid-marquee--express-milo--adobecom.aem.page/express/?martech=off

Verification Steps

  • Steps to reproduce the issue or view the new feature.
  • What to expect before and after the change.

Potential Regressions

  • https://--express-milo--adobecom.aem.live/express/?martech=off

Additional Notes

(If applicable) Add context, related PRs, or known issues here.

@aem-code-sync

aem-code-sync Bot commented Nov 6, 2025

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@yeibercano

Copy link
Copy Markdown
Contributor Author
Screenshot 2025-11-06 at 1 15 09 PM

@aem-code-sync

aem-code-sync Bot commented Nov 6, 2025

Copy link
Copy Markdown
Page Scores Audits
📱 /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@codecov-commenter

codecov-commenter commented Nov 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.85%. Comparing base (580aee2) to head (5d053aa).
⚠️ Report is 239 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #758      +/-   ##
==========================================
- Coverage   70.86%   70.85%   -0.01%     
==========================================
  Files         108      108              
  Lines       24744    24744              
==========================================
- Hits        17535    17533       -2     
- Misses       7209     7211       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yeibercano
yeibercano marked this pull request as ready for review November 6, 2025 21:32
@github-actions github-actions Bot added the Ready for Review Ready for peer review. label Nov 6, 2025
@yeibercano
yeibercano requested a review from hadobe November 6, 2025 21:32
@hadobe hadobe added QA Approved QA testing has been completed. and removed Ready for QA labels Dec 2, 2025
@express-milo-merge-bot

Copy link
Copy Markdown
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

5 similar comments
@express-milo-merge-bot

Copy link
Copy Markdown
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@express-milo-merge-bot

Copy link
Copy Markdown
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@express-milo-merge-bot

Copy link
Copy Markdown
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@express-milo-merge-bot

Copy link
Copy Markdown
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@express-milo-merge-bot

Copy link
Copy Markdown
Contributor

Error merging 758: Nala: resolve WebKit timing issue in grid-marquee Pull Request is not mergeable - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

@thedoc31 thedoc31 added stale No recent activity autoclose-pending Will be auto-closed soon labels Aug 24, 2026
@thedoc31

Copy link
Copy Markdown
Contributor

No activity in 7 days. Will be labeled stale at 14 days. Auto-close is disabled this run. Add stale-ignore to exempt.

No activity in 14 days — labeled stale. Auto-close is disabled this run. Add stale-ignore to exempt.

No activity in 21 days — labeled autoclose-pending. Would normally close in 7 days, but auto-close is disabled this run. Add autoclose-ignore to exempt.

No activity in 28 days. Would normally close now, but auto-close is disabled this run. Add autoclose-ignore to exempt.


Live rollout: adobecom+Adobe-acom 10-repo sample, run by casalino via Claude Code

@adobecom-git-stale-pr-bot adobecom-git-stale-pr-bot Bot removed stale No recent activity autoclose-pending Will be auto-closed soon labels Sep 3, 2026
@adobecom-git-stale-pr-bot

Copy link
Copy Markdown

No activity in 7 days. Will be labeled stale at 14 days. Auto-close is disabled this run. Add stale-ignore to exempt.


Rundeck job Git Stale PR Check (git-stale-pr-bot), execution 2739336, project global, run by casalino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design Review Not Required QA Approved QA testing has been completed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants