MWPW-183006 [M@S Studio] Staged Content Flag

[bozojovicic]

Resolves https://jira.corp.adobe.com/browse/MWPW-183006
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Fragments and promotions can now be marked as Staged with a switch button. If user tries to publish them the warning dialog will be displayed where user can confirm or cancel the publish operation. Also in bulk publish project if some fragment is Staged the same dialog will be displayed. We have new column "Workflow status" in table for fragments and promotions where user can see if they are marked as Staged.

The tag /cq:tags/mas/studio/internal/staged is used to mark fragments and promotions as Staged.

Please do the steps below before submitting your PR for a code review or QA

• C1. Cover code with Unit Tests
• C2. Add a Nala test (double check with #fishbags if nala test is needed)
• C3. Verify all Checks are green (unit tests, nala tests)
• C4. PR description contains working Test Page link where the feature can be tested
• C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
• C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

1. Add the run nala label to this PR (in the right sidebar)
2. Tests will run automatically on the current commit
3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

• Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

• Before: https://main--mas--adobecom.aem.live/
• After: https://mwpw-183006--mas--adobecom.aem.live/

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

• Re-sync branch

Commits

• f064852 ✅ (latest)
• 03ce297 ✅
• 89f29cf ✅
• b358984 ✅
• 160e213 ✅
• 4d40c2e ✅
• 8aee98c ✅
• 8418553 ✅
• 0c1ced4 ✅
• 9a28845 ✅
• 7497e32 ✅
• fd9fd05 ✅
• b2608d6 ✅
• 8259f98 ✅
• 9d97d80 ✅
• a5abe80 ✅
• b8fabd7 ✅
• 22dc027 ✅
• eb95875 ✅
• ed1da63 ✅
• e1b12f6 ✅
• 54d90a1 ✅
• 5d610e4 ✅
• 83d0327 ✅
• 9998d51 ✅

[github-actions]

SNOW Change Request Transaction ID [STUDIO]: 0000019c1ef37582-1f6e6559

[codecov]

Codecov Report

❌ Patch coverage is 85.98901% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.70%. Comparing base (d09c40c) to head (f064852).

Files with missing lines	Patch %	Lines
studio/src/mas-fragment-editor.js	45.00%	11 Missing ⚠️
studio/src/editors/merch-card-editor.js	52.38%	10 Missing ⚠️
studio/src/mas-selection-panel.js	89.04%	8 Missing ⚠️
studio/src/editors/merch-card-collection-editor.js	70.83%	7 Missing ⚠️
studio/src/bulk-publish/mas-bulk-publish-editor.js	88.67%	6 Missing ⚠️
studio/src/editor-panel.js	71.42%	4 Missing ⚠️
studio/src/promotions/mas-promotions-editor.js	86.20%	4 Missing ⚠️
studio/src/mas-repository.js	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
- Coverage   90.74%   90.70%   -0.05%     
==========================================
  Files         316      317       +1     
  Lines      101499   101845     +346     
==========================================
+ Hits        92101    92374     +273     
- Misses       9398     9471      +73     

Files with missing lines	Coverage Δ
studio/src/aem/fragment.js	97.00% <100.00%> (+0.08%)	⬆️
studio/src/bulk-publish/bulk-publish-utils.js	100.00% <100.00%> (ø)
...dio/src/bulk-publish/mas-bulk-publish-items.css.js	100.00% <100.00%> (ø)
studio/src/bulk-publish/mas-bulk-publish-items.js	98.83% <100.00%> (+0.05%)	⬆️
studio/src/bulk-publish/mas-bulk-publish.js	88.34% <100.00%> (+0.05%)	⬆️
studio/src/mas-content.js	91.51% <100.00%> (+0.75%)	⬆️
studio/src/mas-fragment-table.js	85.29% <100.00%> (+0.30%)	⬆️
studio/src/publish/mas-publish-staged-dialog.js	100.00% <100.00%> (ø)
studio/src/reactivity/source-fragment-store.js	89.36% <100.00%> (+0.35%)	⬆️
studio/src/mas-repository.js	81.04% <80.00%> (-0.01%)	⬇️
... and 7 more

... and 11 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09c40c...f064852. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Roycethan]

@bozojovicic

1. Although the variation ( in this case its Grouped variation) is not marked as 'Staged' its showing as staged in table view - it should not inherit the status from the parent fragment
   https://mwpw-183006--mas--adobecom.aem.live/studio.html?#bulkPublishProjectId=a0e79af0-3999-47c6-84ee-42afc95b2590&fragmentId=05d728a5-d54e-4da8-bd6a-064f7444efaf&page=fragment-editor&path=sandbox

2)On Bulk publish - Staged items are shown via the existing error-status renderer (same visual treatment as "404 URL not found"), which could read as "broken" rather than "intentionally staged" -

3. Publishing a non-staged parent with a staged variation attached publishes that staged variation with No warning --- When publishing non staged parent with staged variation it should prompt the message which should indicate that a variation is staged

4)Multi select: when i select staged and not-staged and marked as Staged from action-bar - 2 calls made , although it doesn't add duplicate tag to the already staged fragment its better not to make re-request right ? This is Minor ...

5. Moving to Dev since this also need address the Multi selct action bar Figma request from design

[bozojovicic]

@reuben Items 1, 3 and 4 should be fixed now.
For item 5 I'm waiting for Frauke to align with Lucy and decide which icon will be used.
I will ask her to check with Lucy also for item 2 - how to display Staged fragments in that table.

[bozojovicic]

@Roycethan Items 2 and 5 also fixed now (Agreed with Lucy and Frauke)