MWPW-193415: [wcs] switch to pre-formatted price - #1180
Open
joaquinrivero wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 90.63% 90.68% +0.04%
==========================================
Files 308 308
Lines 99164 99290 +126
==========================================
+ Hits 89881 90039 +158
+ Misses 9283 9251 -32
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
joaquinrivero
force-pushed
the
MWPW-193415
branch
from
August 25, 2026 17:45
4bc96db to
6c6af6a
Compare
joaquinrivero
force-pushed
the
MWPW-193415
branch
from
August 25, 2026 17:50
6c6af6a to
9d07ce0
Compare
joaquinrivero
force-pushed
the
MWPW-193415
branch
from
August 25, 2026 19:59
9d07ce0 to
6dba224
Compare
joaquinrivero
force-pushed
the
MWPW-193415
branch
from
August 25, 2026 20:05
6dba224 to
fa90406
Compare
joaquinrivero
force-pushed
the
MWPW-193415
branch
from
August 25, 2026 20:13
fa90406 to
e7b6cd4
Compare
joaquinrivero
force-pushed
the
MWPW-193415
branch
from
August 25, 2026 20:44
e7b6cd4 to
d3f45c9
Compare
joaquinrivero
force-pushed
the
MWPW-193415
branch
from
August 25, 2026 23:41
d3f45c9 to
e6f78ec
Compare
joaquinrivero
force-pushed
the
MWPW-193415
branch
3 times, most recently
from
August 25, 2026 23:52
25dec11 to
d153d8a
Compare
joaquinrivero
force-pushed
the
MWPW-193415
branch
from
August 25, 2026 23:57
d153d8a to
ea2287a
Compare
npeltier
reviewed
Aug 26, 2026
| * @param { boolean } usePrecision | ||
| * @returns {{ currencySymbol: string, decimals: string, decimalsDelimiter: string, hasCurrencySpace: boolean, integer: string, isCurrencyFirst: boolean } | null} | ||
| */ | ||
| const splitFormattedPrice = (formatted, formatString, usePrecision) => { |
Contributor
There was a problem hiding this comment.
@joaquinrivero if we are going to hack around the price string, let's not repeat original mistake, and ask WCS team to return
currencySymbol,
decimals,
decimalsDelimiter,
hasCurrencySpace,
integer,
isCurrencyFirst,
directly in priceInfo, wdyt?
* origin/main: MWPW-205209 Merch Icon URLs Relative (#1188) MWPW-200943: load entitlements from the offer found by ID search (#1156) MWPW-206050: limit executions to only our runners (#1189) MWPW-204765 CTA data-key field in RTE (#1167) MWPW-204645: Reduce promotions editor Odin load for large projects (#1160) # Conflicts: # web-components/dist/commerce.js # web-components/dist/mas.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-193415
Switches WCS price rendering to the pre-formatted priceInfo strings from WCS instead of client-side formatting of priceDetails, for the price types WCS pre-formats
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: