Skip to content

MWPW-201776: MAS Chrome extension - detect prices, CTAs and OSIs outside merch cards - #1193

Open
Axelcureno wants to merge 22 commits into
mainfrom
MWPW-201776
Open

MWPW-201776: MAS Chrome extension - detect prices, CTAs and OSIs outside merch cards#1193
Axelcureno wants to merge 22 commits into
mainfrom
MWPW-201776

Conversation

@Axelcureno

@Axelcureno Axelcureno commented Aug 31, 2026

Copy link
Copy Markdown
Member

Extends the MAS Chrome extension's card-detector to also surface bare inline-price/checkout-link/checkout-button elements (data-wcs-osi) outside merch-card, which today are invisible despite being most MAS content on product pages. Reuses existing cancel-context promo handling unchanged.

Resolves https://jira.corp.adobe.com/browse/MWPW-201776
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (extension isn't in Nala scope; confirm with #fishbags)
  • C3. Verify all Checks are green (71/71 unit tests, merge-checked against main)
  • C4. PR description contains working Test Page link
  • C5. Ready to demo from Test Page
  • C.6 Re-read Jira to confirm all ACs addressed

Test: no deployed branch URL applies (browser extension). Load unpacked from this branch (chrome://extensions) against any page with a standalone inline-price/checkout-link/checkout-button. Not yet smoke-tested live in browser — flagging before merge/QA.

Extends the Chrome extension's card-detector to surface bare
inline-price/checkout-link/checkout-button elements (matched via
data-wcs-osi), which today are invisible unless wrapped in a
merch-card. Nested-in-card elements are excluded to avoid double
counting. Overlay/popup UI branch to a leaner "OSI" view for these
since there's no backing AEM fragment to fetch.
@aem-code-sync

aem-code-sync Bot commented Aug 31, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.74%. Comparing base (2f2e131) to head (42b447e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
+ Coverage   90.71%   90.74%   +0.02%     
==========================================
  Files         318      318              
  Lines      101712   101712              
==========================================
+ Hits        92271    92300      +29     
+ Misses       9441     9412      -29     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2e131...42b447e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Axelcureno Axelcureno self-assigned this Aug 31, 2026
@Axelcureno Axelcureno changed the title MWPW-201776: Detect prices, CTAs and OSIs outside merch cards MWPW-201776: M@S Extension detect prices, CTAs and OSIs outside merch cards Aug 31, 2026
@Axelcureno Axelcureno changed the title MWPW-201776: M@S Extension detect prices, CTAs and OSIs outside merch cards MWPW-201776: MAS Chrome extension - detect prices, CTAs and OSIs outside merch cards Aug 31, 2026

@mirafedas mirafedas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on https://www.adobe.com/express/?promoid=Y69SGP43&mv=other and https://www.adobe.com/products/illustrator.html , prices and CTAs outside merch cards are detected correctly ✅

@seanchoi0 seanchoi0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, approving! One thing worth a quick check — overlay.js renders the "Additional details" section unconditionally in the template, but if (isBareElement) return (around line 130) exits before the toggle listener gets attached. Might be worth verifying that clicking it on a price/cta panel behaves as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants