MWPW-201776: MAS Chrome extension - detect prices, CTAs and OSIs outside merch cards - #1193
MWPW-201776: MAS Chrome extension - detect prices, CTAs and OSIs outside merch cards#1193Axelcureno wants to merge 22 commits into
Conversation
Extends the Chrome extension's card-detector to surface bare inline-price/checkout-link/checkout-button elements (matched via data-wcs-osi), which today are invisible unless wrapped in a merch-card. Nested-in-card elements are excluded to avoid double counting. Overlay/popup UI branch to a leaner "OSI" view for these since there's no backing AEM fragment to fetch.
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 90.71% 90.74% +0.02%
==========================================
Files 318 318
Lines 101712 101712
==========================================
+ Hits 92271 92300 +29
+ Misses 9441 9412 -29 see 4 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
mirafedas
left a comment
There was a problem hiding this comment.
Tested on https://www.adobe.com/express/?promoid=Y69SGP43&mv=other and https://www.adobe.com/products/illustrator.html , prices and CTAs outside merch cards are detected correctly ✅
seanchoi0
left a comment
There was a problem hiding this comment.
Looks good overall, approving! One thing worth a quick check — overlay.js renders the "Additional details" section unconditionally in the template, but if (isBareElement) return (around line 130) exits before the toggle listener gets attached. Might be worth verifying that clicking it on a price/cta panel behaves as expected.
Extends the MAS Chrome extension's card-detector to also surface bare inline-price/checkout-link/checkout-button elements (data-wcs-osi) outside merch-card, which today are invisible despite being most MAS content on product pages. Reuses existing cancel-context promo handling unchanged.
Resolves https://jira.corp.adobe.com/browse/MWPW-201776
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Test: no deployed branch URL applies (browser extension). Load unpacked from this branch (
chrome://extensions) against any page with a standalone inline-price/checkout-link/checkout-button. Not yet smoke-tested live in browser — flagging before merge/QA.