MWPW-206153: repair desync variations field in - #1194
Conversation
live copies.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
+ Coverage 90.55% 90.59% +0.03%
==========================================
Files 312 312
Lines 100837 100837
==========================================
+ Hits 91316 91351 +35
+ Misses 9521 9486 -35 see 6 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
I think it checks too fast and still sees the old value although the change is applied. |
| return; | ||
| } | ||
|
|
||
| if (!apply) { |
There was a problem hiding this comment.
Nit: Suspend/resume errors do not include liveCopyId. If resume fail in finally (line 208-213), original write error swallowed, live copy stays suspended, log shows no id/rootPath. Concurrency=4 means logs interleave — operator can't tell which live copy needs a manual fix.
Fix: Embed liveCopyId in error msg:
if (!response.ok) throw new Error(resume ${liveCopyId} -> ${response.status} ${await response.text().catch(() => '')});
mirafedas
left a comment
mirafedas
left a comment
There was a problem hiding this comment.
Approving with one nit comment
Axelcureno
left a comment
Axelcureno
left a comment
There was a problem hiding this comment.
Ran your script in dry-run against the same fragment: all 38 are [] and unsuspended, so those 10 MISMATCH errors were just AEM's read lagging the write. Worth a retry before throwing, since right now a clean run still exits 1.
Also, from repo root the .env lookup hits mas/.env first and never sees scripts/content/.env, so it only works if you cd in. And dotenv is in package.json but unused.
3 participants
live copies.
script runs in dry run mode by default, use
--applyto write.Resolves https://jira.corp.adobe.com/browse/MWPW-206153
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs:
Output