MWPW-205543 Copy Fields: Group CTAs as a blob - #1197
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
# Conflicts: # studio/src/editors/variation-utils.js # studio/src/mas-side-nav.js # web-components/dist/commerce.js # web-components/dist/mas-field.js # web-components/dist/mas.js # web-components/dist/merch-card.js
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
+ Coverage 90.76% 90.82% +0.06%
==========================================
Files 318 319 +1
Lines 101699 102055 +356
==========================================
+ Hits 92304 92691 +387
+ Misses 9395 9364 -31
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…review styling Widen the 3-option CTA variant picker (Primary/Secondary/Link) from the headless template to Marquee and Banner/Blade, and match the rendered preview: gap between CTAs, a comma separator, and a subtle gray variant label next to each button.
# Conflicts: # web-components/dist/mas.js # web-components/dist/merch-card-collection.js # web-components/dist/merch-card.js
There was a problem hiding this comment.
@Blainegunn Feedbacks:
- CTA links are now not showing the commitment step/workflow in the editor and in the links:
Expected:
- Standalone CTA when copied they are rendering as 3 copies of CTA's with lost button styling ( See Buy now: and Free_trial:) in the page:
https://main--da-cc--adobecom.aem.page/fragments/reuben/head-marquee?maslibs=mwpw-205543&milolibs=mwpw-205543
| * CTAs with no real <strong>/<em> wrapper (see variation-utils.js#parseCtas). */ | ||
| export function getCtaEmphasis(className) { | ||
| if (!className) return null; | ||
| if (className.includes('primary') && !className.includes('-link')) return 'bold'; |
There was a problem hiding this comment.
Returns null for accent, but resolveHeadlessDisplayVariant returns 'primary', copies without <strong>. whatabout? if (className.includes('accent')) return 'bold';
# Conflicts: # web-components/dist/mas.js # web-components/dist/merch-card-collection.js # web-components/dist/merch-card.js
Fixed |





Resolves https://jira.corp.adobe.com/browse/MWPW-205543
Copy/Paste all CTAs for Headless use cases.
3 Style variants supported: default/link, bold/primary, italics/secondary
Test Page
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: