MWPW-203850: Add data-replaced-osi and data-locked-osi to merch-card - #1201
Draft
seanchoi0 wants to merge 7 commits into
Draft
MWPW-203850: Add data-replaced-osi and data-locked-osi to merch-card#1201seanchoi0 wants to merge 7 commits into
seanchoi0 wants to merge 7 commits into
Conversation
…merch-card - wcs.js: track original OSIs before promo substitution, set fields.replacedOsi - merch-card.js: add lockedOsi and replacedOsi getter/setter pairs (setAttribute/removeAttribute) - hydrate.js: wire fields.osi → lockedOsi and fields.replacedOsi → replacedOsi on card Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
==========================================
+ Coverage 90.74% 90.75% +0.01%
==========================================
Files 316 316
Lines 101499 101534 +35
==========================================
+ Hits 92101 92145 +44
+ Misses 9398 9389 -9
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
seanchoi0
force-pushed
the
MWPW-203850
branch
from
September 3, 2026 15:31
5770f73 to
9416598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decorates the
merch-cardelement with two new data attributes to assist M@S Extension troubleshooting and reuse.Resolves https://jira.corp.adobe.com/browse/MWPW-203850
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Changes:
data-replaced-osi(new): set bywcs.jsIO transformer when the Promo Project substitutes an OSI — contains the original OSI(s) before substitution, comma-separated if multipledata-locked-osi(bug fix): set byhydrate.jsfromfields.osi— reflects the card-level locked OSI in the DOMC1. Cover code with Unit Tests
C2. Add a Nala test (double check with #fishbags if nala test is needed)
C3. Verify all Checks are green (unit tests, nala tests)
C4. PR description contains working Test Page link where the feature can be tested
C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing
Test URLs: