MWPW-199855: Add Fragment Paste feature to promos Consolidate Items Selector - #1206
Open
Andrei4226 wants to merge 6 commits into
Open
MWPW-199855: Add Fragment Paste feature to promos Consolidate Items Selector#1206Andrei4226 wants to merge 6 commits into
Andrei4226 wants to merge 6 commits into
Conversation
|
SNOW Change Request Transaction ID [STUDIO]: 0000019c1eec85a3-20b770b1 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
- Coverage 90.76% 90.72% -0.04%
==========================================
Files 319 318 -1
Lines 101832 101758 -74
==========================================
- Hits 92428 92322 -106
- Misses 9404 9436 +32
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-199855
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Consolidate promotions item picker with the shared items selector
Removed the duplicate
mas-promotions-items-selectorcomponent and switched promotions to use the same sharedmas-items-selectorcomponent already used by translations and other pickers so same UI, less code to maintain, same behavior as before for promotions.Test link: https://mwpw-199855--mas--adobecom.aem.live/studio.html#page=promotions-editor&path=sandbox&promotionId=134e22a3-c428-487a-8197-377471e6a690
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: