Skip to content

MWPW-199855: Add Fragment Paste feature to promos Consolidate Items Selector - #1206

Open
Andrei4226 wants to merge 6 commits into
mainfrom
MWPW-199855
Open

MWPW-199855: Add Fragment Paste feature to promos Consolidate Items Selector#1206
Andrei4226 wants to merge 6 commits into
mainfrom
MWPW-199855

Conversation

@Andrei4226

@Andrei4226 Andrei4226 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Resolves https://jira.corp.adobe.com/browse/MWPW-199855
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Consolidate promotions item picker with the shared items selector

Removed the duplicate mas-promotions-items-selector component and switched promotions to use the same shared mas-items-selector component already used by translations and other pickers so same UI, less code to maintain, same behavior as before for promotions.

  • Made the shared selector configurable enough to cover promotions needs (offer/surface filters, promo variation table) without duplicating logic.
  • Enabled the "Import via URL" feature for promotions (previously missing there).
  • Imported fragments in promotions must now belong to one of the surfaces and one of the offers already selected on the promotion project, otherwise they're rejected with a clear message.
  • No behavior change for translations or other existing consumers of "Import via URL" or item selection.

Test link: https://mwpw-199855--mas--adobecom.aem.live/studio.html#page=promotions-editor&path=sandbox&promotionId=134e22a3-c428-487a-8197-377471e6a690

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@Andrei4226 Andrei4226 self-assigned this Sep 3, 2026
@aem-code-sync

aem-code-sync Bot commented Sep 3, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

SNOW Change Request Transaction ID [STUDIO]: 0000019c1eec85a3-20b770b1

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.48780% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.72%. Comparing base (3174cbf) to head (f69e72c).

Files with missing lines Patch % Lines
studio/src/promotions/mas-promotions-editor.js 83.41% 33 Missing ⚠️
studio/src/common/components/mas-items-selector.js 94.49% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
- Coverage   90.76%   90.72%   -0.04%     
==========================================
  Files         319      318       -1     
  Lines      101832   101758      -74     
==========================================
- Hits        92428    92322     -106     
- Misses       9404     9436      +32     
Files with missing lines Coverage Δ
...io/src/common/components/mas-items-selector.css.js 100.00% <100.00%> (ø)
...io/src/common/components/mas-search-and-filters.js 91.35% <100.00%> (-0.80%) ⬇️
studio/src/common/utils/render-utils.js 100.00% <100.00%> (ø)
studio/src/promotions/promotion-editor-utils.js 99.05% <100.00%> (-0.12%) ⬇️
studio/src/common/components/mas-items-selector.js 98.07% <94.49%> (-0.03%) ⬇️
studio/src/promotions/mas-promotions-editor.js 92.01% <83.41%> (-0.60%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3174cbf...f69e72c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant