Skip to content

MWPW-206423: Apply promos to prices inside custom fields - #1208

Open
Axelcureno wants to merge 8 commits into
mainfrom
MWPW-206423
Open

MWPW-206423: Apply promos to prices inside custom fields#1208
Axelcureno wants to merge 8 commits into
mainfrom
MWPW-206423

Conversation

@Axelcureno

Copy link
Copy Markdown
Member

customFields arrives as an array, not a string, so scanMasElements skipped it and promos never reached custom-field prices.

Resolves https://jira.corp.adobe.com/browse/MWPW-206423
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

Test URLs:

scanMasElements skipped customFields because it is the only multi-value
rich text field, so Odin returns its value as an array of strings rather
than a single string. OSI substitution and WCS prefill never reached
prices authored inside a custom field, so headless cards kept rendering
the non-promo offer for every geo with a substitute rule.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnjyktFjNJfbWGh3JnEmu8
@aem-code-sync

aem-code-sync Bot commented Sep 3, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

SNOW Change Request Transaction ID [IO]: 0000019c1eec85a3-20c52b14

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.76%. Comparing base (d06ea2e) to head (da9598d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
- Coverage   90.81%   90.76%   -0.05%     
==========================================
  Files         319      319              
  Lines      101857   101857              
==========================================
- Hits        92498    92450      -48     
- Misses       9359     9407      +48     

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06ea2e...da9598d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquinrivero
joaquinrivero self-requested a review September 4, 2026 19:22
Comment thread studio/libs/swc.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why a new swc build is needed. If swc must be changed, I would expect also package-lock.json to be in the PR.

@afmicka

afmicka commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@Axelcureno had something overwritten your IO namespace for this PR? I don't see the fix
Screenshot 2026-09-07 at 12 50 39

Will see later if i merge something else but given your automatic branch updates, we will need to coordinate validation of your PRs with IO changes.

@afmicka afmicka removed the run nala label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants