MWPW-206423: Apply promos to prices inside custom fields - #1208
MWPW-206423: Apply promos to prices inside custom fields#1208Axelcureno wants to merge 8 commits into
Conversation
scanMasElements skipped customFields because it is the only multi-value rich text field, so Odin returns its value as an array of strings rather than a single string. OSI substitution and WCS prefill never reached prices authored inside a custom field, so headless cards kept rendering the non-promo offer for every geo with a substitute rule. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnjyktFjNJfbWGh3JnEmu8
|
SNOW Change Request Transaction ID [IO]: 0000019c1eec85a3-20c52b14 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
- Coverage 90.81% 90.76% -0.05%
==========================================
Files 319 319
Lines 101857 101857
==========================================
- Hits 92498 92450 -48
- Misses 9359 9407 +48 see 11 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
not sure why a new swc build is needed. If swc must be changed, I would expect also package-lock.json to be in the PR.
|
@Axelcureno had something overwritten your IO namespace for this PR? I don't see the fix Will see later if i merge something else but given your automatic branch updates, we will need to coordinate validation of your PRs with IO changes. |

customFieldsarrives as an array, not a string, soscanMasElementsskipped it and promos never reached custom-field prices.Resolves https://jira.corp.adobe.com/browse/MWPW-206423
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Test URLs: