MWPW-206405 Title added to Banner / Blade Template - #1209
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 90.76% 90.74% -0.03%
==========================================
Files 318 318
Lines 101699 101701 +2
==========================================
- Hits 92304 92284 -20
- Misses 9395 9417 +22
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@Blainegunn A dedicated test would be great to add for Title field in banner template
else LGTM
Axelcureno
left a comment
There was a problem hiding this comment.
marquee.js:8 does the identical thing with tag: 'p', and both are in HEADLESS_FAMILY_VARIANTS. Any reason banner-blade uses h3? The family CSS neutralizes heading typography either way, so it's just the DOM semantics that differ.
On Reuben's test ask: merch-card.marquee-faq-banner-blade.test.js:115 already has the rows map, just needs 'heading-xs': 'Title'. Its name says "a slot for each mapped field" but it now covers 2 of 3.
Resolves https://jira.corp.adobe.com/browse/MWPW-206405
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: