MWPW-206522: render mas-field as display:contents - #1210
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
+ Coverage 90.71% 90.75% +0.03%
==========================================
Files 318 318
Lines 101712 101717 +5
==========================================
+ Hits 92271 92312 +41
+ Misses 9441 9405 -36
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Axelcureno
left a comment
There was a problem hiding this comment.
Worth noting Milo's merch.css already sets mas-field { display: contents }, so this mainly fixes non-Milo hosts and drops the divergence. preview.css:836's comment still cites display: inline, stale now, but the override wins on specificity either way.
Roycethan
left a comment
There was a problem hiding this comment.
@joaquinrivero Regression observed:
"Free trial" shifts right by 16px (past one phantom span+gap), and "Buy now" shifts by 32px (past two)
https://main--da-cc--adobecom.aem.live/products/premiere/plans?maslibs=MWPW-206522&milolibs=MWPW-202435
Lets Milo keep the mas-field wrapper around inline CTAs instead of unwrapping it, so commerce context survives by structure. A contents box is transparent, so layout is unchanged.
bd15dbf to
c4b82a9
Compare
Good catch. The comment is fixed in #6586. |
Resolves https://jira.corp.adobe.com/browse/MWPW-206522
mas-fieldasdisplay: contents.Companion PR (milo): adobecom/milo#6586
Test URLs: