Skip to content

MWPW-204749-0: Consolidate injectJsonLd cardTitle handling for long-text field shapes - #1211

Open
Andrei4226 wants to merge 2 commits into
mainfrom
MWPW-204749-0
Open

MWPW-204749-0: Consolidate injectJsonLd cardTitle handling for long-text field shapes#1211
Andrei4226 wants to merge 2 commits into
mainfrom
MWPW-204749-0

Conversation

@Andrei4226

@Andrei4226 Andrei4226 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Resolves https://jira.corp.adobe.com/browse/MWPW-204749
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Defensive consolidation for injectJsonLd: cardTitle is becoming a long-text (RTE) field, same as description. Unwraps cardTitle the same way description already is before using it as JSON-LD name, in case it's ever passed as {mimeType, value}.

Verified in Milo (merch-card-autoblock.js, the only caller of injectJsonLd): fields is already normalized to plain strings before reaching this function, so cardTitle will keep working exactly as today. This change is optional/non-blocking , just included for consolidation, not because it's required for the field-type change to be safe.

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@Andrei4226 Andrei4226 self-assigned this Sep 4, 2026
@aem-code-sync

aem-code-sync Bot commented Sep 4, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.78%. Comparing base (6729934) to head (ac18f94).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   90.76%   90.78%   +0.02%     
==========================================
  Files         318      318              
  Lines      101699   101701       +2     
==========================================
+ Hits        92304    92327      +23     
+ Misses       9395     9374      -21     
Files with missing lines Coverage Δ
web-components/src/json-ld.js 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6729934...ac18f94. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yesil

yesil commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@Andrei4226 please resolve the conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants