MWPW-204749-0: Consolidate injectJsonLd cardTitle handling for long-text field shapes - #1211
Open
Andrei4226 wants to merge 2 commits into
Open
MWPW-204749-0: Consolidate injectJsonLd cardTitle handling for long-text field shapes#1211Andrei4226 wants to merge 2 commits into
Andrei4226 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
==========================================
+ Coverage 90.76% 90.78% +0.02%
==========================================
Files 318 318
Lines 101699 101701 +2
==========================================
+ Hits 92304 92327 +23
+ Misses 9395 9374 -21
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
yesil
approved these changes
Sep 7, 2026
Contributor
|
@Andrei4226 please resolve the conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-204749
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Defensive consolidation for
injectJsonLd:cardTitleis becoming along-text(RTE) field, same asdescription. UnwrapscardTitlethe same waydescriptionalready is before using it as JSON-LDname, in case it's ever passed as{mimeType, value}.Verified in Milo (
merch-card-autoblock.js, the only caller ofinjectJsonLd):fieldsis already normalized to plain strings before reaching this function, socardTitlewill keep working exactly as today. This change is optional/non-blocking , just included for consolidation, not because it's required for the field-type change to be safe.Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: